Re: [PATCH 04/15] block: use queue_limits_commit_update in queue_max_sectors_store

Damien Le Moal
2024-01-23T05:07:21Z

On 1/23/24 02:36, Christoph Hellwig wrote:
> Convert queue_max_sectors_store to use queue_limits_commit_update to
> check and updated the max_sectors limit and freeze the queue before

s/updated/update

> doing so to ensure we don't have request in flight while changing

s/request/requests

> the limits.
>
> Note that this removes the previously held queue_lock that doesn't
> protect against any other read or writer.

s/read/reader

>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Other than these typos, looks good to me.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

--
Damien Le Moal
Western Digital Research