From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73170CF9C6C for ; Wed, 25 Sep 2024 05:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WC5lMWPOQJyCMDITxuBay9ED03WWOnQxMVAZM6detzs=; b=hpnsi690LsKS5ZNRFTLZyGKfwG GMHKibxfMKNOnDbTe80hguupV9XdOfbmXlvqSop3zC7wa3Im1BK1vzT8x/aP+yqIWRuAtI8owjmWC sP5yvwweiPuAEjvUTFpYvCvRoG5GLwIile3wB+IcZev583SuX3qJ2+jjlA0GwZ+4JAoGCkOCf4EfT ccSs9cCaTIa91/t+WvcO9duP8A7XzLSDgVDU5qa/0ALn7DQRHs0B4BOsy0EHzKqsxbcEtgGtx3Sr8 n14gE85JYj+5MNpZYvRI1pe8XfyovGj/PKEen5KrcUlvwKVUmfcpe/Y5xty4wxIC7DH75upppXlUD u32Dqfhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stKtF-000000046M3-3hL7; Wed, 25 Sep 2024 05:48:41 +0000 Received: from smtp-out1.suse.de ([195.135.223.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stKtB-000000046Ky-03XE for linux-nvme@lists.infradead.org; Wed, 25 Sep 2024 05:48:40 +0000 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3B33D211E5; Wed, 25 Sep 2024 05:48:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1727243315; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WC5lMWPOQJyCMDITxuBay9ED03WWOnQxMVAZM6detzs=; b=atHRudHw4gBD0qUXsdWoWwdoyXfPXvIBS2A+KbXSHk0CrsNiA3a6OGFUWRhIc6mk3ysasV 3HdjxlflV638ltA9o2Ktg5WNy7Qeh4tLixH+xX+4gzdSIGUF/bljn3N8bm3IN6lBiI3lYh iYdqnQISjqEK75rTtpMPrRxWJB6LlKk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1727243315; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WC5lMWPOQJyCMDITxuBay9ED03WWOnQxMVAZM6detzs=; b=F4UfQTWzbznrvneSEC8Lv/HkKkdGj9H5jaap5pNTs6fMQhal/zdNlNranqs4t29fM8m756 rTNQDg/00eX0LsBQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1727243315; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WC5lMWPOQJyCMDITxuBay9ED03WWOnQxMVAZM6detzs=; b=atHRudHw4gBD0qUXsdWoWwdoyXfPXvIBS2A+KbXSHk0CrsNiA3a6OGFUWRhIc6mk3ysasV 3HdjxlflV638ltA9o2Ktg5WNy7Qeh4tLixH+xX+4gzdSIGUF/bljn3N8bm3IN6lBiI3lYh iYdqnQISjqEK75rTtpMPrRxWJB6LlKk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1727243315; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WC5lMWPOQJyCMDITxuBay9ED03WWOnQxMVAZM6detzs=; b=F4UfQTWzbznrvneSEC8Lv/HkKkdGj9H5jaap5pNTs6fMQhal/zdNlNranqs4t29fM8m756 rTNQDg/00eX0LsBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 604D913A66; Wed, 25 Sep 2024 05:48:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id LABIDTCk82azVAAAD6G6ig (envelope-from ); Wed, 25 Sep 2024 05:48:32 +0000 Message-ID: Date: Wed, 25 Sep 2024 07:48:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/3] nvme: enable FDP support To: Kanchan Joshi , axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, martin.petersen@oracle.com, brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jaegeuk@kernel.org, bcrl@kvack.org, dhowells@redhat.com, bvanassche@acm.org, asml.silence@gmail.com Cc: linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-block@vger.kernel.org, linux-aio@kvack.org, gost.dev@samsung.com, vishak.g@samsung.com, javier.gonz@samsung.com, Hui Qi , Nitesh Shetty References: <20240924092457.7846-1-joshi.k@samsung.com> <20240924092457.7846-2-joshi.k@samsung.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20240924092457.7846-2-joshi.k@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_TO(0.00)[samsung.com,kernel.dk,kernel.org,lst.de,grimberg.me,oracle.com,zeniv.linux.org.uk,suse.cz,kvack.org,redhat.com,acm.org,gmail.com]; TAGGED_RCPT(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[24]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240924_224837_233695_5CF50639 X-CRM114-Status: GOOD ( 13.83 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 9/24/24 11:24, Kanchan Joshi wrote: > Flexible Data Placement (FDP), as ratified in TP 4146a, allows the host > to control the placement of logical blocks so as to reduce the SSD WAF. > > Userspace can send the data lifetime information using the write hints. > The SCSI driver (sd) can already pass this information to the SCSI > devices. This patch does the same for NVMe. > > Fetch the placement-identifiers if the device supports FDP. > The incoming write-hint is mapped to a placement-identifier, which in > turn is set in the DSPEC field of the write command. > > Signed-off-by: Kanchan Joshi > Signed-off-by: Hui Qi > Signed-off-by: Nitesh Shetty > --- > drivers/nvme/host/core.c | 70 ++++++++++++++++++++++++++++++++++++++++ > drivers/nvme/host/nvme.h | 4 +++ > include/linux/nvme.h | 19 +++++++++++ > 3 files changed, 93 insertions(+) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich