Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH v3 7/7] nvme: don't remove namespace if revalidate failed because of a transport error
Date: Sat, 10 Aug 2019 22:28:39 -0700	[thread overview]
Message-ID: <da217f10-97de-2eae-4e60-92ff84fb8014@grimberg.me> (raw)
In-Reply-To: <16b63247-f020-5522-ffab-9404ba7b3408@suse.de>


> This is a neat solution, yet I'm not convinced that it'll solve the 
> problem entirely. I'll give it a spin.

Thanks Hannes,

Note that with tcp/rdma, there is another patch needed to pass
this test.

See:
[PATCH rfc] nvme: make all fabrics command run on a separate request queue

The reason is, that because we have admin commands making their way
to the target between we disable the controller and (re)enable it
as part of the reset process. Because of that, we have the target
failing some of the scan commands that are wrongly made it through
(which cause the scan work to wrongly remove the ns and hang).

So I would recommend running it with that patch as well (and also
get your feedback on it ;))

  reply	other threads:[~2019-08-11  5:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08 20:53 [PATCH v3 0/7] nvme controller reset and namespace scan work race conditions Sagi Grimberg
2019-08-08 20:53 ` [PATCH v3 1/7] nvme: fail cancelled commands with NVME_SC_HOST_PATH_ERROR Sagi Grimberg
2019-08-10 11:59   ` Hannes Reinecke
2019-08-08 20:53 ` [PATCH v3 2/7] nvme: return nvme_error_status for sync commands failure Sagi Grimberg
2019-08-10 12:06   ` Hannes Reinecke
2019-08-08 20:53 ` [PATCH v3 3/7] nvme: make nvme_identify_ns propagate errors back Sagi Grimberg
2019-08-08 21:18   ` Keith Busch
2019-08-08 23:22     ` Sagi Grimberg
2019-08-10 12:09   ` Hannes Reinecke
2019-08-08 20:53 ` [PATCH v3 4/7] nvme: make nvme_report_ns_ids propagate error back Sagi Grimberg
2019-08-10 12:10   ` Hannes Reinecke
2019-08-08 20:53 ` [PATCH v3 5/7] nvme-tcp: fail command with NVME_SC_HOST_PATH_ERROR send failed Sagi Grimberg
2019-08-10 12:10   ` Hannes Reinecke
2019-08-08 20:53 ` [PATCH v3 6/7] nvme-fc: Fail transport errors with NVME_SC_HOST_PATH Sagi Grimberg
2019-08-10 12:11   ` Hannes Reinecke
2019-08-08 20:53 ` [PATCH v3 7/7] nvme: don't remove namespace if revalidate failed because of a transport error Sagi Grimberg
2019-08-10 12:14   ` Hannes Reinecke
2019-08-11  5:28     ` Sagi Grimberg [this message]
2019-08-08 23:26 ` [PATCH v3 0/7] nvme controller reset and namespace scan work race conditions Bart Van Assche
2019-08-08 23:33   ` Sagi Grimberg
2019-08-08 23:57     ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da217f10-97de-2eae-4e60-92ff84fb8014@grimberg.me \
    --to=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox