From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Klaus Jensen <its@irrelevant.dk>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Klaus Jensen <k.jensen@samsung.com>
Subject: Re: [PATCH] nvme: fix write zeroes pi
Date: Wed, 10 Nov 2021 06:10:18 +0000 [thread overview]
Message-ID: <db739cda-2dd7-015a-5ad9-d2d6e44131c6@nvidia.com> (raw)
In-Reply-To: <20211104181618.864157-1-its@irrelevant.dk>
Klaus,
On 11/4/2021 11:16 AM, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Write Zeroes sets PRACT when block integrity is enabled (as it should),
> but neglects to also set the reftag which is expected by reads. This
> causes protection errors on reads.
>
> Fix this by setting the reftag for type 1 and 2 (for type 3, reads will
> not check the reftag).
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Patch looks good to me but did you get a chance to test on
multiple non-QEMU controllers ?
next prev parent reply other threads:[~2021-11-10 6:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 18:16 [PATCH] nvme: fix write zeroes pi Klaus Jensen
2021-11-05 3:23 ` Martin K. Petersen
2021-11-10 6:10 ` Chaitanya Kulkarni [this message]
2021-11-10 9:16 ` Klaus Jensen
2021-11-11 5:06 ` Chaitanya Kulkarni
2021-11-10 8:43 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db739cda-2dd7-015a-5ad9-d2d6e44131c6@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox