From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH v3] nvmet-rdma: Correctly handle RDMA device hot removal
Date: Tue, 2 Aug 2016 09:39:48 +0300 [thread overview]
Message-ID: <dc6286c3-a5c0-48a8-284d-f53b6830da22@grimberg.me> (raw)
In-Reply-To: <20160801155054.GD22771@lst.de>
>>> How is ->remove_port synchronized vs the RDMA/CM even handler?
>>
>> Easy, it isn't :)
>>
>> So we have three choices here:
>> 1. Add a lock in nvmet_port that only rdma will use for now (don't like
>> it)
>> or
>> 2. Add nvmet_rdma_port as nvmet_port->priv with a lock (don't like it)
>> or
>> 3. take the global nvmet_config_sem (hate it)
>>
>> Any preferences?
>
> (4) use cmpxchg?
I'm not exactly sure what you mean. Do you mean placing
cmpxchg in nvmet_rdma_device_removal()? To what we cmp
when we want to xchg?
Care to explain in a bit more detail?
next prev parent reply other threads:[~2016-08-02 6:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 12:15 [PATCH v3] nvmet-rdma: Correctly handle RDMA device hot removal Sagi Grimberg
2016-08-01 11:15 ` Christoph Hellwig
2016-08-01 11:30 ` Sagi Grimberg
2016-08-01 15:50 ` Christoph Hellwig
2016-08-02 6:39 ` Sagi Grimberg [this message]
2016-08-02 12:53 ` Christoph Hellwig
2016-08-01 14:44 ` Bart Van Assche
2016-08-01 15:09 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc6286c3-a5c0-48a8-284d-f53b6830da22@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).