From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>
Cc: Kanchan Joshi <joshi.k@samsung.com>, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 3/3] nvme: don't allow unprivileged passthrough on partitions
Date: Thu, 12 Jan 2023 14:23:06 +0100 [thread overview]
Message-ID: <df4da166-9fc3-11af-7481-2da452c04d35@suse.de> (raw)
In-Reply-To: <20230108165033.380842-4-hch@lst.de>
On 1/8/23 17:50, Christoph Hellwig wrote:
> Passthrough commands can always access the entire device, and thus
> submitting them on partitions is an privelege escalation.
>
> In hindsight we should have never allowed any passthrough commands on
> partitions, but it's probably too late to change that decision now.
>
> Fixes: e4fbcf32c860 ("nvme: identify-namespace without CAP_SYS_ADMIN")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/nvme/host/ioctl.c | 47 ++++++++++++++++++++++++++-------------
> 1 file changed, 31 insertions(+), 16 deletions(-)
>
Doesn't a similar argument hold for ctrl vs ns-specific commands?
Otherwise:
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
next prev parent reply other threads:[~2023-01-12 13:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230108165424epcas5p2b6d079dfcc8b1a91692f19729cc45b9a@epcas5p2.samsung.com>
2023-01-08 16:50 ` don't allow unprivileged passthrough on partitions Christoph Hellwig
2023-01-08 16:50 ` [PATCH 1/3] nvme: remove __nvme_ioctl Christoph Hellwig
2023-01-09 7:34 ` Chaitanya Kulkarni
2023-01-12 13:20 ` Hannes Reinecke
2023-01-08 16:50 ` [PATCH 2/3] nvme: replace the "bool vec" arguments with flags in the ioctl path Christoph Hellwig
2023-01-09 7:39 ` Chaitanya Kulkarni
2023-01-12 13:21 ` Hannes Reinecke
2023-01-08 16:50 ` [PATCH 3/3] nvme: don't allow unprivileged passthrough on partitions Christoph Hellwig
2023-01-09 7:40 ` Chaitanya Kulkarni
2023-01-12 13:23 ` Hannes Reinecke [this message]
2023-01-12 14:03 ` Christoph Hellwig
2023-01-09 10:45 ` Kanchan Joshi
2023-01-09 15:13 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df4da166-9fc3-11af-7481-2da452c04d35@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox