From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21653606A31C for ; Mon, 16 Nov 2026 07:38:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=frYRe80y; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=p7M2++Wt; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=f/UGNQvS; dkim=neutral header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=bHL/yrAc; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=H3wpifoo DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=zZmXLBv2SE8smt4ibe6ROyBZVESDWUHzTn/j6advAGk=; b=frYRe80yO7R968 YVyytm9MuNFhAIaCeZ0TMy3O9IKc/p26Lzu/cqN2BqLF7T7OXM9YAec1cN7r835acyl52RubHQfZC 3+Bk90fDZNgQcVCY5a5r8MsV1zVP6TlbIFPNqZNRgdrqDFgfoNwUoNdA+9acl8AQ3+BDzeWPaN3+O hQE9pZq1W6j2XIAdUTfSWLUMyZY/nnji1lqkZByUv3HUt/aRyc+AQ94UX8SWtwbtjM2708VGaqIc2 o1km776nsQCvNeVRGpC6N8aJ31HzVJwX7qmOKquL+LYmBCcnPQOiEB6wstpomUdD48+LWj3pr3Mkb H8/04VHe3a33OFR7Di4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xSrIj-00000001Qcy-3DyE; Mon, 16 Nov 2026 07:38:53 +0000 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xSrIg-00000001Qah-2Ya5 for linux-nvme@lists.infradead.org; Mon, 16 Nov 2026 07:38:51 +0000 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EE6D02222D; Mon, 16 Nov 2026 07:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1794814728; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zZmXLBv2SE8smt4ibe6ROyBZVESDWUHzTn/j6advAGk=; b=p7M2++WtRlYfqeXK3QMXCq31pL0sZrl5V93SsUuO7MsRWD1LfWEygzljfImAhUihiu6/GP Qy6UUVtqx4WNThF4sWJkvI0+Ys0RBvkUlFaDLeqMr8RlSw9nWVpJ62aWLBHEwf8CTnvlUk hXPH6IlqC+abRm1hYitiEfTXej/RBbs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1794814728; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zZmXLBv2SE8smt4ibe6ROyBZVESDWUHzTn/j6advAGk=; b=f/UGNQvSz9XWqeZySBa8OcucY6x/YP8EWgLvntqwxCRfW+KAjhJ9BxOgV3A8YJMSPNENzt QdjwrZxUZrcmZBBg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1794814727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zZmXLBv2SE8smt4ibe6ROyBZVESDWUHzTn/j6advAGk=; b=bHL/yrAco6yPxag2Tl1k26zZ0PbMrkp6Q/LGv1Na/KuiE4hwKi8dIy4h03WLQTASxwD3xL hNTYQmZLCJjBiSgXZTvTwbgGwi7OdSmVr0Hzj84l+8DjKiECPz3fmRVQFuIJ97Q1nl8ox+ Qm0ke8I0UtTDBkU9+2wbttbdxb0Eh4k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1794814727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zZmXLBv2SE8smt4ibe6ROyBZVESDWUHzTn/j6advAGk=; b=H3wpifooAX3wceqQ8Xas1R4ppbzumIX5XggxuKdZSgr5KjUpKf6VmuI40AbnPUzUnln5p8 73xGOOc5cnIMrgBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5C63D134B8; Mon, 16 Nov 2026 07:38:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 6D+ECwez+mqFMwAAD6G6ig (envelope-from ); Mon, 16 Nov 2026 07:38:47 +0000 Message-ID: Date: Mon, 16 Nov 2026 08:38:46 +0100 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 14/17] nvme-fc: Use CCR to recover controller that hits an error To: Mohamed Khalfella , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: Naresh Gottumukkala , Paul Ely , Hannes Reinecke , Chaitanya Kulkarni , James Smart , Randy Jennings , Daniel Wagner , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20261114030454.2836543-1-mkhalfella@purestorage.com> <20261114030454.2836543-15-mkhalfella@purestorage.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20261114030454.2836543-15-mkhalfella@purestorage.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Level: X-Spamd-Result: default: False [-13.29 / 50.00]; SUSE_INTERNAL_BYPASS(-9.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWELVE(0.00)[14]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,broadcom.com,kernel.org,nvidia.com,purestorage.com,suse.de,lists.infradead.org,vger.kernel.org]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,purestorage.com:email,suse.de:email] X-Spam-Score: -13.29 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261115_233850_835280_3F916871 X-CRM114-Status: GOOD ( 11.74 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 11/14/26 4:04 AM, Mohamed Khalfella wrote: > A LIVE controller that hits an error now moves to FENCING instead of > RESETTING. ctrl->fencing_work attempts CCR to terminate inflight IOs. > Regardless of the success or failure of the CCR operation, the > controller then moves to RESETTING to continue error recovery. > > nvme_fc_fencing_work() tears down the association before fencing so > the LLDD can finish unregistering the remoteport/localport. With this > patch alone that still completes the inflight requests at the start of > the fence, which matches the behavior before this series. The next > patch holds them until fencing has finished. > > Signed-off-by: Mohamed Khalfella > --- > drivers/nvme/host/fc.c | 69 ++++++++++++++++++++++++++++++++++++------ > 1 file changed, 59 insertions(+), 10 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich