Re: [PATCH 1/2] nvme: remove support or stream based temperature hint

Jens Axboe
2022-03-04T19:38:13Z

On 3/4/22 12:36 PM, Christoph Hellwig wrote:
> On Fri, Mar 04, 2022 at 11:34:39AM -0800, Keith Busch wrote:
>> On Fri, Mar 04, 2022 at 06:55:55PM +0100, Christoph Hellwig wrote:
>>> - ctrl->nssa = le16_to_cpu(s.nssa);
>>> - if (ctrl->nssa < BLK_MAX_WRITE_HINTS - 1) {
>>> - dev_info(ctrl->device, "too few streams (%u) available\n",
>>> - ctrl->nssa);
>>> - goto out_disable_stream;
>>> - }
>>
>> Just fyi, looks like the patch was built against an older version of the
>> driver, so it doesn't apply cleanly to nvme-5.18 at the above part.
>>
>> Also please consider folding the following in this patch since it removes all
>> nr_streams use:
>
> This was against Jens' for-5.18/block tree. I'm a bit lost what tree
> to best send it against as there will always be some conflicts.

It's always a bit of a problem when patches touch both drivers and core.
I actually put this one in a special branch just because of that. I'll
fold in Keith's incremental.

--
Jens Axboe