Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: AlanCui4080 <me@alancui.cc>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, Pascal Terjan <pterjan@google.com>
Subject: Re: The wrong usage of NVME_QUIRK_IGNORE_DEV_SUBNQN
Date: Fri, 08 May 2026 18:11:18 +0800	[thread overview]
Message-ID: <e0Qdery1QcSgRO30DoVH-A@alancui.cc> (raw)
In-Reply-To: <af2YtHjq3mhWiyJA@kbusch-mbp>

Hi Busch,

On Friday, 8 May 2026 16:03,you wrote:

> Okay, please send a revert. The number of devices that got such
> fundamental things wrong is truly astounding, so I generally just take
> such reports and patches as a reaction to a real observation.

The patch contains a revert has been sent to mailling list.

I've only recently started using Linux desktop on a physical machine
and am trying to contribute. Sorry for my recklessness.

A patch attached for reference. If the Linux kernel explicitly
states in documents that it won't perform a quirk in this situation,
perhaps I can go to those BBS forums to correct their statements. And
this may help to avoid wrong usage of quirks like My and Terjan's patch.

Alan.

---
diff --git a/Documentation/nvme/feature-and-quirk-policy.rst b/Documentation/nvme/feature-and-quirk-policy.rst
index e21966bf20a8..9d9e791da692 100644
--- a/Documentation/nvme/feature-and-quirk-policy.rst
+++ b/Documentation/nvme/feature-and-quirk-policy.rst
@@ -75,3 +75,18 @@ Quirks will not be added to the Linux kernel for hardware that isn't available
 on the mass market.  Hardware that fails qualification for enterprise Linux
 distributions, ChromeOS, Android or other consumers of the Linux kernel
 should be fixed before it is shipped instead of relying on Linux quirks.
+
+NVME_QUIRK_IGNORE_DEV_SUBNQN
+-------------------------
+
+The incorrect implementations of SUBNQN is a known issue in a massive number of
+NVMe units.  However, the warning "nvme nvmex: missing or invalid SUBNQN field."
+is usually appropriate and will not affect performance or behavior etc.  That is
+because the support for SUBNQN is mandatory if the controller supports NVMe
+revision 1.2.1 or greater, and it reported itself without a SUBNQN field which
+breaks compliance with the specification. This should be not quirked by the Linux
+Kernel.
+
+The intent of NVME_QUIRK_IGNORE_DEV_SUBNQN is to solve the NQN confliction caused
+by defective firmware that provides a non-globally-unique NQN.  When multiple
+such devices are installed in a system, only one will be recognized and enabled.





      parent reply	other threads:[~2026-05-08 10:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07 18:20 The wrong usage of NVME_QUIRK_IGNORE_DEV_SUBNQN AlanCui4080
2026-05-08  8:03 ` Keith Busch
2026-05-08  9:59   ` [PATCH] Revert "nvme: add quirk NVME_QUIRK_IGNORE_DEV_SUBNQN for 144d:a808" AlanCui4080
2026-05-11 15:01     ` Keith Busch
2026-05-08 10:11   ` AlanCui4080 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0Qdery1QcSgRO30DoVH-A@alancui.cc \
    --to=me@alancui.cc \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=pterjan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox