Re: [PATCH v4 05/18] dma-mapping: Add check if IOVA can be used

Leon Romanovsky
2024-12-12T08:45:45Z

On Thu, Dec 12, 2024 at 09:34:59AM +0100, Christoph Hellwig wrote:
> On Thu, Dec 05, 2024 at 03:21:04PM +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia.com>
> >
> > This patch adds a check if IOVA can be used for the specific
> > transaction.
> >
> > In the new API a DMA mapping transaction is identified by a
> > struct dma_iova_state, which holds some recomputed information
> > for the transaction which does not change for each page being
> > mapped.
>
> While the content of the patch here looks fine, the super fine
> grained patch split look really odd and makes sensible review
> hard. Was this a request on one of the earlier versions?

I don't think so. It is combination of two factors:
1. Review cycles, which caused to shrink this patch.
For example, see the amount of content in RFC version of same patch
https://lore.kernel.org/all/cac154df7131984929a1cf73948bc5986af5ef85.1726138681.git.leon@kernel.org/
2. Attempt to localize changes in dma-mapping.h file. The following
patch touches dma-iommu.c, while this doesn't need to do so.

I can squash them.

Thanks