From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64CD0C433E0 for ; Fri, 12 Jun 2020 14:43:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3409B206A4 for ; Fri, 12 Jun 2020 14:43:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gry+r1if" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3409B206A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Mime-Version:References: In-Reply-To:Date:To:From:Subject:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Npln7OVdmDFSx696SJ2UHiWrWRrnFifmoZkpYXc4H84=; b=gry+r1ifx53tVA 3hC8ONMjyza2CCG/6hse11m5ii+NPbp5ZIANuSp0ybv/pCa1Fh+HLC5E2eLRynlcCAmxOjxF6hQ0E zWzthv62LkmW0COvkoFITmGXtP6qoruKArQ1jo37Hvat4yw9Muc3pXXJtbSgY4AodfhC7xUyNNpMH bQ9VgVlhIwkpAQGZtbCVqJDpFVGYuhEZ5yP0t27hk2LFbm1AvHRUk+oGtT9xcabPNuTpGk2Nc3P0i SuZ+nSIXvEuFE4y2M2OEniKB9B6ZZO5f6nNMng7KadgyP74VAXysDPdhvs3mAM7TR4oq/ZfGEDsQd 45fQtx2bPzCY5q9E8JvA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjktt-0001U3-0t; Fri, 12 Jun 2020 14:43:21 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjktq-0001Ti-EB for linux-nvme@lists.infradead.org; Fri, 12 Jun 2020 14:43:19 +0000 IronPort-SDR: cIefuKjzCvyG+9GwtPmW3gtkrTcMordfQEkmOu9K7Q7nUHLxvyrgZu4DM+eVWuhcuTbVBN3h32 KqqZjvrLXBxw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2020 07:43:16 -0700 IronPort-SDR: AqV/Emd7dj5trQzADEwOiVK5jTBxjiFqeQWTsO1wfmpBKAyfsNdqf5aUKKl4+MgIduiFz6DtTH eriRTpf2dKtQ== X-IronPort-AV: E=Sophos;i="5.73,503,1583222400"; d="scan'208";a="307253098" Received: from dfugate-mobl1.amr.corp.intel.com (HELO dwf-u18040) ([10.212.216.202]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2020 07:43:16 -0700 Message-ID: Subject: Re: [PATCH] nvme: associate stripe size quirk with D4512 From: David Fugate To: Christoph Hellwig Date: Fri, 12 Jun 2020 08:43:15 -0600 In-Reply-To: <20200611054156.GB3518@lst.de> References: <20200611033836.45701-1-david.fugate@linux.intel.com> <20200611054156.GB3518@lst.de> Organization: Intel X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200612_074318_484696_F7A56EF3 X-CRM114-Status: GOOD ( 13.12 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: david.fugate@linux.intel.com Cc: kbusch@kernel.org, axboe@fb.com, sagi@grimberg.me, linux-nvme@lists.infradead.org, david.fugate@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, 2020-06-11 at 07:41 +0200, Christoph Hellwig wrote: > On Wed, Jun 10, 2020 at 09:38:36PM -0600, David Fugate wrote: > > Intel's D4512 dual-port SSD is based on the older Intel P4500 SSDs > > whose development predated the NOIOB feature. Based on a customer > > request, the D4512's device ID was changed from the P4500s'. This > > patch associates D4512's device ID with the stripe size quirk to > > improve its performance. > > NAK. We've been told Intel forever that we need a standard quirk, > and we actually do have way to expose this information in Identify > now. > Just kick your firmware engineers in the but to set the trivial field > in Identify. Thanks for the feedback Christoph. Our FW engineer for this product is currently on vacation, but I'll relay your suggestion to see if it's viable. In the meantime, I'm hearing your rejection for this is simply Intel standardized the driver-assisted striping feature as NOIOB and failed to realize it in any Intel product. Other than this, was there a technical reason for rejecting this patch? Thanks again! _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme