From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Jens Axboe <axboe@kernel.dk>, Sagi Grimberg <sagi@grimberg.me>,
hch@lst.de, kbusch@kernel.org, linux-nvme@lists.infradead.org
Cc: oren@nvidia.com, israelr@nvidia.com
Subject: Re: [RFC PATCH 1/1] nvme: add a dedicated .c file for sysfs interface
Date: Mon, 24 Apr 2023 17:07:15 +0300 [thread overview]
Message-ID: <e4cbb808-5e08-4523-8a6b-929fd31aeac7@nvidia.com> (raw)
In-Reply-To: <4eb35ad9-7422-fd9d-36ea-3f1ef895917e@kernel.dk>
On 24/04/2023 17:04, Jens Axboe wrote:
> On 4/24/23 8:01?AM, Max Gurtovoy wrote:
>> If the only comments I get is for copyright then we're good I guess ?
>
> Didn't closely review it, but conceptually I agree with the change.
> Declutters core.c and usually there's little need to touch the sysfs
> bits.
>
Ok. Let me send it again with fixing the copyright and removing the RFC
and the concept agreed.
prev parent reply other threads:[~2023-04-24 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 13:03 [RFC PATCH 1/1] nvme: add a dedicated .c file for sysfs interface Max Gurtovoy
2023-04-24 13:38 ` Sagi Grimberg
2023-04-24 13:43 ` Max Gurtovoy
2023-04-24 13:56 ` Jens Axboe
2023-04-24 14:01 ` Max Gurtovoy
2023-04-24 14:04 ` Jens Axboe
2023-04-24 14:07 ` Max Gurtovoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4cbb808-5e08-4523-8a6b-929fd31aeac7@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=israelr@nvidia.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=oren@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox