Re: [PATCH blktests v3] nvme/{common/nvme, 016, 017, 051, 052}: introduce def_nsid

[Guixin Liu <kanie@linux.alibaba.com>]

在 2024/11/5 18:30, Shinichiro Kawasaki 写道:
> On Oct 31, 2024 / 18:14, Guixin Liu wrote:
>> Use def_nsid instead of hard code, the default of def_nsid is 1.
>>
>> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
>> Reviewed-by: Daniel Wagner <dwagner@suse.de>
>> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
>> ---
>> Changes from v2 to v3:
>> - Fix 016, 017, 052 do nothing when the def_nsid is set to
>> biger than iterations.(Shinichiro Kawasaki)
>> - Fix "make check" error in 052.(Shinichiro Kawasaki)
> Guixin, thank you for this v3. I've applied the patch.
>
> Unfortunately, this patch caused some conflicts with the series "nvme: prepare
> for ANA support", so I took the liberty to modify this change. Please take a
> look in the commit after the modification [1]. If there is any mistakes, please
> let me know.
>
> [1] https://github.com/osandov/blktests/commit/87d4c0cb93f32b7d0798b9faaed6bb2b39d636a2

Looks like I'm missing to add "local nsid", thanks for modifing this.

Best Regards,

Guixin Liu