From: Hou Pu <houpu.main@gmail.com>
To: "Grupi, Elad" <Elad.Grupi@dell.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH] nvme-tcp: fix a segmentation fault during io parsing error
Date: Wed, 17 Mar 2021 12:11:28 +0800 [thread overview]
Message-ID: <e7286d8a-a364-fdf9-c839-7c5976b4fc70@gmail.com> (raw)
In-Reply-To: <DM6PR19MB40116B3A8A9751C4BA926521EF6B9@DM6PR19MB4011.namprd19.prod.outlook.com>
On 2021/3/16 11:52, Grupi, Elad wrote:
> Hi Hou,
>
> You are correct, this is the same issue.
>
> I have reviewed your patch and I have two concerns:
> 1. As Sagi mentioned, you might not have all the inline data in the socket at this point.
> 2. You might get hit on the last round of the budget of the receive loop, so you will still have a chance of hitting the response flow before reading all the data from the socket.
Yes, I realize my patch has these problems.
Thanks,
Hou
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-17 4:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 11:51 [PATCH] nvme-tcp: fix a segmentation fault during io parsing error elad.grupi
2021-01-13 22:47 ` Sagi Grimberg
2021-01-14 11:51 ` Grupi, Elad
2021-01-14 21:18 ` Sagi Grimberg
2021-01-14 21:41 ` Grupi, Elad
2021-01-16 1:19 ` Sagi Grimberg
2021-01-17 9:46 ` Grupi, Elad
2021-01-31 15:48 ` Grupi, Elad
2021-03-16 9:35 ` Hou Pu
2021-03-16 15:52 ` Grupi, Elad
2021-03-17 4:11 ` Hou Pu [this message]
2021-03-18 8:31 ` Grupi, Elad
2021-03-16 6:21 ` Sagi Grimberg
2021-03-16 15:45 ` Grupi, Elad
2021-03-18 8:31 ` Grupi, Elad
-- strict thread matches above, loose matches on Subject: below --
2021-01-14 13:04 elad.grupi
2021-01-12 14:00 elad.grupi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7286d8a-a364-fdf9-c839-7c5976b4fc70@gmail.com \
--to=houpu.main@gmail.com \
--cc=Elad.Grupi@dell.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox