Re: [RFC PATCHv4 2/3] nvme: introduce multipath_always_on module param

Nilay Shroff
2025-05-14T13:54:44Z

On 5/14/25 11:12 AM, Christoph Hellwig wrote:
> I just applied this locally, but ran into somethig that I think is
> not addressed here. NVMe allows private namespaces to have non-unіque
> nsids if certain features (like ANA) are not enabled. I don't think
> we handle this here, and in fact we can't really support that with
> the multipath node. But we'll at least need to reject that case
> gracefully somehow and document it.

Okay understood. I made the change to ensure that we don't create
multipath node for private namespaces with non-unique NSID even
if multipath_always_on is configured and also documented it in
the code. The changes are on the way...

Thanks,
--Nilay