[PATCH 1/3] nvmet-tcp: fix endianess annotations

Christoph Hellwig
2018-12-16T16:24:57Z

On Thu, Dec 13, 2018@08:42:15AM -0800, Sagi Grimberg wrote:
>
>> @@ -776,7 +776,7 @@ static int nvmet_tcp_handle_icreq(struct nvmet_tcp_queue *queue)
>> icresp->hdr.pdo = 0;
>> icresp->hdr.plen = cpu_to_le32(icresp->hdr.hlen);
>> icresp->pfv = cpu_to_le16(NVME_TCP_PFV_1_0);
>> - icresp->maxdata = 0xffff; /* FIXME: support r2t */
>> + icresp->maxdata = cpu_to_le32(0xffff); /* FIXME: support r2t */
>> icresp->cpda = 0;
>> if (queue->hdr_digest)
>> icresp->digest |= NVME_TCP_HDR_DIGEST_ENABLE;
>
> This needs an actual fix, we need to send 0xffffffff as we don't have
> this any limitation..

Can I get an ACK for this for now? I can also send the proper fix
on top then..