From: alan.adamson@oracle.com
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, kch@nvidia.com,
kbusch@kernel.org, sagi@grimberg.me
Subject: Re: [PATCH 2/2] nvme: all namespaces in a subsystem must adhere to a common atomic write size
Date: Tue, 6 May 2025 08:57:35 -0700 [thread overview]
Message-ID: <e8a55150-54fd-4519-977c-2468aa573137@oracle.com> (raw)
In-Reply-To: <20250502065239.GA8227@lst.de>
On 5/1/25 11:52 PM, Christoph Hellwig wrote:
> On Wed, Apr 30, 2025 at 10:18:30AM -0700, Alan Adamson wrote:
>> The first namespace that is configured in a subsystem will define the
>> subsystem's atomic write size. This will be based on either AWUPF or
>> NAWUPF. Configuring subsequent namespaces in the subsystem requires its
>> atomic write size as defined by its AWUPF or NAWUPF to match the
>> subsystem's atomic write size. If a namespace doesn't adhere to the
>> subsystem's atomic write size, its atomic queue limits will be based on an
>> atomic write size of 512 bytes and an error message will be logged.
Along with the error message, we are setting atomic_write_max_bytes to
512b which will at least allow the device to still be used.
Alan
> I don't think an error message is enough, we need to reject the probe
> for this buggy configuration to prevent data integrity issues.
>
> Otherwise the series looks good to me.
>
next prev parent reply other threads:[~2025-05-06 20:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 17:18 [PATCH 0/2] NVMe Atomic Write fixes Alan Adamson
2025-04-30 17:18 ` [PATCH 1/2] nvme: multipath: atomic queue limits need to be inherited Alan Adamson
2025-05-01 5:47 ` John Garry
2025-05-01 6:06 ` John Garry
2025-04-30 17:18 ` [PATCH 2/2] nvme: all namespaces in a subsystem must adhere to a common atomic write size Alan Adamson
2025-05-02 6:52 ` Christoph Hellwig
2025-05-06 15:57 ` alan.adamson [this message]
2025-05-07 6:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8a55150-54fd-4519-977c-2468aa573137@oracle.com \
--to=alan.adamson@oracle.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox