From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A59E4C77B73 for ; Thu, 27 Apr 2023 08:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ds0pQTUorwJh0w96eKM6TsYu2kPylWstMAbQovOR8i4=; b=WaCId5DZ7lxgwxTnSsP89BLLPL B07sCxR2j93ZDZS76omZusNZng1fVJIT5rahiNpG6Q0s0Ze170xYFL9to+5YY3uzDEY/8zFWq/lOd AWVvaMZi3/VBkSlDK/VeqqLuynJi9VGbCbfMssupop3rIhIrrO6FVpzHr5GgmvUtlgBWvVCw5+Py7 MPgSxCAqpv2Qu/IfmNcBIA4Fsrtl4EnlV3gZLhpdFoDMltQ2A9b7tFMN9J/YoefgjSyC8ADEmEDYI edPWyQ/FmLZv2r7cvYuYSf9RDIjLBM2QmsrkNmT1ajgWKliTtXwNKu0ugECXJi+2KUX8B3i8dculW qj2j+nRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1prx3o-005pNs-1H; Thu, 27 Apr 2023 08:33:04 +0000 Received: from mail-dm6nam12on2061b.outbound.protection.outlook.com ([2a01:111:f400:fe59::61b] helo=NAM12-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1prx3l-005pMm-2M for linux-nvme@lists.infradead.org; Thu, 27 Apr 2023 08:33:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AkxuE2s2R2FlO7CG9NShG1pSWIHHl+qmm/nPrUnQNzE42XNyUWQAbHVbRh4pqTbt40zw3uf9rtfbkFAuEi9QDtafNsjP+KqsWgddk6dfIR4lt4K/t+1j1nuJJ6/gXoPX5pMOvnEAF7hpi2FmLzvJUT0HJ9tuv4WeCmJq28g/L/cSzgXIEJyBeBaPQowMfl51ZrKLR7Pk827iYgyohx+c+ARxNBJUlTsSAFLZ1892zvwUpifgIVNJY/8pCyQ2PIP/InSiTAXRvGvS+V0Es1iGLAD3d0MBBbPF2sGszL3FTrhIqZ6AtfW0l/I5ICAFgalcpZEIbn8lniBtLX9aW0NPtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ds0pQTUorwJh0w96eKM6TsYu2kPylWstMAbQovOR8i4=; b=FNpg2DQmwbRaqI77645DCOTvVwtN1umXGk9f7bAa2F0Yo5/JL6eF4X9LAb/8EQSyT7NoJoOFivJnHr+eIH6Xtu3WeX8UKjrb2Dk2VXOxVCmuZRHjvNvzREK8QSLaqq/QHki0BRbE7x3hwUyaXAOOo1oRH6or1y6Z6RrsIZTcnDqenGJ7dXnWQmxXSjLdq/39TyNM1FYaXXHoqYZfj8oIevlw0FB3c/Rwr7d5EoEt+dJWTK3MJJu+mzI2e1pKrFghm6Cupjw/O/IqQ0v0F0wXJT6A6nHCkLmOgzFQG3gLub/WW96p06LyRFUPKurLvwOP8bn/dSWP2NE2/oXWIeHm7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ds0pQTUorwJh0w96eKM6TsYu2kPylWstMAbQovOR8i4=; b=J95w0izP3pS90PvuqoeGip2hcCUGNOONDj5VPjTlVQbwL8/Jzvhw8kYFm+qDRp9S5EjxjhJn5XvB3sXvALcb/ZD3qQFyClGZ7BrQoy4kDpYjfU39YMIQIbf3IPDVuW4tlfhXGDqJVMp+LztZORoONddfTQX7+DHbnHfykbTUNChlQ8fhO2AjWLSCcebK8HaJMddsXxdw2gOZ0ohW2/uuaVQ47mSnQdUFthMlT+q4+Wt8DWiLPWybPRzOU5ff4iIihuDswl1GIaLEyLLWpMcgpEQMweezY/ya8o23kxwy4usFzkJWKCsEWyKgzEPMaC3xQPl0jE6Y8ESoYVZx6j3PjQ== Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28) by DS0PR12MB6629.namprd12.prod.outlook.com (2603:10b6:8:d3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Thu, 27 Apr 2023 08:32:58 +0000 Received: from MW2PR12MB4667.namprd12.prod.outlook.com ([fe80::6922:cae7:b3cc:4c2a]) by MW2PR12MB4667.namprd12.prod.outlook.com ([fe80::6922:cae7:b3cc:4c2a%6]) with mapi id 15.20.6340.021; Thu, 27 Apr 2023 08:32:58 +0000 From: Chaitanya Kulkarni To: Sagi Grimberg , Chaitanya Kulkarni , "hare@suse.de" CC: "kbusch@kernel.org" , "hch@lst.de" , "linux-nvme@lists.infradead.org" Subject: Re: [PATCH 1/2] nvme-core: fix memory leak in dhchap_secret_store Thread-Topic: [PATCH 1/2] nvme-core: fix memory leak in dhchap_secret_store Thread-Index: AQHZeN8AAu5R/JFntE6I3cw1EJIg7K8+zW4AgAAGkQA= Date: Thu, 27 Apr 2023 08:32:58 +0000 Message-ID: References: <20230427080456.18232-1-kch@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW2PR12MB4667:EE_|DS0PR12MB6629:EE_ x-ms-office365-filtering-correlation-id: 9e0492a1-a164-422f-099d-08db46fa0173 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rm7vgLinJCX8icLYOrNrDlLpWxNxJC3r3v32lHBa02UIiKmIcBRKRtDCx+/q0ByTVSGqdu3odP7m//Q/Yy1Lc+4GwYTLdmMgR9oXzr3/JUVgANz3Y595r8zPNVObuNtOpYE6Qdej6eUr0M8zWd29MGwF/cQUfviesfIKvuPMmj6QmPJJ+nCW9/1jgvviLSNI6CtY45KXxnMfB1VL+4+Kirmj9rGuJ8lSaC7JKQGCuany5fzEBbJ+hyNIxEnE3rXLIu21iwqjSOLbOTkQigGvFPElPdaft9G/QmrhzvmWwf1UDuW+MzH9Dl2SUnntaDcYKDnFN5562yKNHyyt0fdzPFUZ9Yl+yscqjO8qZiGZyIEu4LQIt4BhXnqJ95BlcwavA6xc4L6QH5dFUo07yVbghc8hZlBQkI5rOzzlIwu+7aPgnehToSULiAbuUhoU9KDEfXFSskEibsApciKRqigbildCUuKKY/yofSEyEU2+uMA+oZa/Ub+HVisrtTydyJL69ROZGUOJy03ilwo6UTw0bjKLdqgcJJHQ/ptCEcC47A4HMwVWbSHv1McW4nAUx67ibZ9L3uONJXThjA1KFaWya1kqo7ZccsUbfxXtEeDRNvZmdtCeB5/y90+stK0trjCBMEF1Vm+frJjN9+zL2r9zPD7wzwHeBicdUkSBMNEG9DGjv04b0t+kjeb4ghKnDEMk3JmAgskeRyp8HQ7IB66YAA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(366004)(39860400002)(136003)(376002)(451199021)(2616005)(122000001)(38100700002)(5660300002)(31686004)(2906002)(6512007)(53546011)(6506007)(41300700001)(38070700005)(83380400001)(8676002)(8936002)(4326008)(316002)(66946007)(66476007)(76116006)(66446008)(66556008)(64756008)(91956017)(478600001)(31696002)(86362001)(186003)(36756003)(54906003)(110136005)(6486002)(71200400001)(219293001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YWpteGVGbDE4NUl2VW1pazZzNVo5WUEvUTNnMmVraUZKWkN1bGxPMWp5empW?= =?utf-8?B?eUxWVjdHSEVIcWREZWNIdEd1aG1qTHhvUjhDN0ZIeTd0bXIrdWE1OVpxVXI3?= =?utf-8?B?K0VhR0o0TVF4dWZwT0FwWXRrOEYrRTk3OFNCWWcwVkZmMzE2eE44WEcxdTR6?= =?utf-8?B?Q1VYVUpINXRFR2NJWStVaFM1ck94UnRmU0dTWkxIZzF6VzNLdTlRSVRtNXpT?= =?utf-8?B?RndKZmxBQzJiaFkxek43VkY0SEYyMWVob3RKKzBlQlN5cE9nMlBwcG9FR3Z4?= =?utf-8?B?dTlZMWhZVWptVW10TnF4SHhMWWZOUnhyVk5HV0tTM1BtV3ZLSEs1OXlvMzZD?= =?utf-8?B?UnhkUUhwM0FsS2k1WkZldTRZbkFEUlZQeEJyY21qRkp2VFVxMlVLczVzWFZO?= =?utf-8?B?Z3lxd2NFSFJnbXRwY2dxcHVzRmZqZEliTmhCUGlXeVo3QWlGZFBhR0pnRVhv?= =?utf-8?B?M1E3NTNsVmlCSFRlNGJTYjRIVGErUE9MUFJWWUc4OGhveU1VMXBjY2V3RkNV?= =?utf-8?B?d2FDc0t0QTZBem5QS0I0VVpMcTBOa2ljYjZnS3JIOTlVTW9GbUpYR1g3SE1n?= =?utf-8?B?L3Z2VmxtbTNDTTRXejJyZnRnWEF6b3BneXI0RlVnck1sOHZ2OEVkY2xIYzVn?= =?utf-8?B?bVhuZCtveWM4MG5KSDUyL0ZrbGRuYnUwSE00NHZGczRmV2dxV3FTekxzMGpa?= =?utf-8?B?Mm1kK2MvbmdWSG5YYll5a0RXSkkzTEVFWFpsa2Zaek5zaEo0NzVwL3JkbnJH?= =?utf-8?B?UW1nOHRja3V1VlYwM3dxbnhCbFRnUjNoYlFTZUM0TlVIR3ZERUpVZzBSemF6?= =?utf-8?B?bXU2KzIxMXpmbVdaVjR0WTg2TDkza21XRDU1Nlo2dlFadFJHRjNsWC8wa3R5?= =?utf-8?B?akRvQmpmTUhxREdIdVhmMTRiRTBTdmdocmNWWGF5RHRMM1FJNWx4T3hseGhU?= =?utf-8?B?NVNnYTZ6T3dJa3RVVnZOOEtUdnBhTVp2MEQvSWRHUmdIMWl3dGJoK2IreHhk?= =?utf-8?B?YkNvN1JIWjA1aC9Rb1FrRk1Qc3p1bkVJeVlxUUVMdld4aVc1enhYWjdRU1pI?= =?utf-8?B?Rjl5QlJoZVhTREMxRStIMWNGVm14QXJGZ0J4WHIrS1VUYzFRVnJ6dVBzUFlp?= =?utf-8?B?eTJTWFFrZkF4bnF2dGNSOENpTENjQ215VkJSR1hwVnAyQnhScVpEblF0R0l4?= =?utf-8?B?aXUzYnZJcjRVNjdnN2lxdFpZUGNLcEk2NjBEbzZCYzV1aVFWUmZmbFgwUFJ3?= =?utf-8?B?eXFqK3ZxSU5QT1NMN0V2T2RBQUpqWEpYbkRhUmdObytuVWVUQmd3Z2V4MGZz?= =?utf-8?B?aEpQRlVEMXhOV3hLZEJYL3VJalpYMUJOd1VOMWRUZ0hWUElnanQ1WVN6NGhE?= =?utf-8?B?WktIeUY2OHB3dnFlTUI0K2s1cmNmanpjSVZJZ2Z0ZHlvWGZweTFuNG45STNy?= =?utf-8?B?M2pabTE2UG9zOENmMjNFb2ZmTWh4NGNSRVVXekRvdXJJeGF6WlgyVlVsNnkw?= =?utf-8?B?MkwxVDV2eGlNQThnWnRJNkFHQUdvRXF0ZUJON2FwbTJiNXZIVUNWRTNCQUFH?= =?utf-8?B?ZCtOd3JOZk9tS1V6UHJBUEhaR2dhTWRKK2gwWURDYlU0R1ZYWDdyQ1B1OVk2?= =?utf-8?B?RzBDYkRYeUE3NFlGaDVPbUtCUERhRUxxb3JEcElqOGVZYXdybU1BRHZBZ2lx?= =?utf-8?B?NlFaUWc4UXZZR0FzYnIxZ003NVdVRThqb2FrTnVLbDVuaTVXUjRucTMyckFC?= =?utf-8?B?djJWWFV4ZVRoMlVYTlFzeEFhYks2bnBuUTZqRTQ3RHFWTnplOFhnRlFiUWxO?= =?utf-8?B?VGdvTmEvbnJEMm03TTBUOTAvcCtjdjI0UEN0a0sxWFZBZlFvblpEKzZnRUVK?= =?utf-8?B?VENhSCtPRm85V1BoUUZzVkUrblNKVHJrYTN5R3RHYVVIK1dQekJjMEowY0xO?= =?utf-8?B?UGhkbTZuTFpPOVlyOEZ6YngzNUFaY0IxSWplUzdJZksrTHgxbVJwQW55QUx4?= =?utf-8?B?ZWtJUEE0Mm1yeTdEbGJ6N0g5aXFMdVVaa2NKSWF0NVMrcjFISWgxTU9NRVph?= =?utf-8?B?Mks2Umt6SWM3NW9iTWltVDdKKzFCOHJWbTh2Y2NadC91anN6TWYrZXcwS0po?= =?utf-8?B?Vkd4MVVqRXJ4UFllSHlaTXlzY1JlVU5pTGlxV3ZBdVAzMk03ZXM4ZWVUSzB0?= =?utf-8?Q?D61dR6jI8JDh1EnGsH5+umwrjL6SnzktGxgfNP0kxC57?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e0492a1-a164-422f-099d-08db46fa0173 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2023 08:32:58.3011 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XbtP58zNfXkqDlqTAHNaLBZ58PHkGZr0+97+O7cQxj8GAdKScR/wfP2wdnTJRzjIOW44tJx9pGqs7/OdMw7nTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6629 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230427_013301_778369_EB3B40D8 X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org T24gNC8yNy8yMyAwMTowOSwgU2FnaSBHcmltYmVyZyB3cm90ZToNCj4gTmVlZHMgYSBmaXhlcyB0 YWcNCj4NCj4gT24gNC8yNy8yMyAxMTowNCwgQ2hhaXRhbnlhIEt1bGthcm5pIHdyb3RlOg0KPj4g RnJlZSBkaGNoYXBfc2VjcmV0IGluIG52bWVfY3RybF9kaGNoYXBfc2VjcmV0X3N0b3JlKCkgYmVm b3JlIHdlIHJldHVybg0KPj4gd2hlbiBudm1lX2F1dGhfZ2VuZXJhdGVfa2V5KCkgcmV0dXJucyBl cnJvci4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBDaGFpdGFueWEgS3Vsa2FybmkgPGtjaEBudmlk aWEuY29tPg0KPj4gLS0tDQo+PiDCoCBkcml2ZXJzL252bWUvaG9zdC9jb3JlLmMgfCA0ICsrKy0N Cj4+IMKgIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4+ DQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9udm1lL2hvc3QvY29yZS5jIGIvZHJpdmVycy9udm1l L2hvc3QvY29yZS5jDQo+PiBpbmRleCA1MThjNzU5MzQ2ZjAuLjVhOWQ5N2MwYzBjMSAxMDA2NDQN Cj4+IC0tLSBhL2RyaXZlcnMvbnZtZS9ob3N0L2NvcmUuYw0KPj4gKysrIGIvZHJpdmVycy9udm1l L2hvc3QvY29yZS5jDQo+PiBAQCAtMzgxNCw4ICszODE0LDEwIEBAIHN0YXRpYyBzc2l6ZV90IA0K Pj4gbnZtZV9jdHJsX2RoY2hhcF9zZWNyZXRfc3RvcmUoc3RydWN0IGRldmljZSAqZGV2LA0KPj4g wqDCoMKgwqDCoMKgwqDCoMKgIGludCByZXQ7DQo+PiDCoCDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0 ID0gbnZtZV9hdXRoX2dlbmVyYXRlX2tleShkaGNoYXBfc2VjcmV0LCAma2V5KTsNCj4+IC3CoMKg wqDCoMKgwqDCoCBpZiAocmV0KQ0KPj4gK8KgwqDCoMKgwqDCoMKgIGlmIChyZXQpIHsNCj4+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIGtmcmVlKGRoY2hhcF9zZWNyZXQpOw0KPj4gwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHJldDsNCj4+ICvCoMKgwqDCoMKgwqDCoCB9DQo+PiDC oMKgwqDCoMKgwqDCoMKgwqAga2ZyZWUob3B0cy0+ZGhjaGFwX3NlY3JldCk7DQo+PiDCoMKgwqDC oMKgwqDCoMKgwqAgb3B0cy0+ZGhjaGFwX3NlY3JldCA9IGRoY2hhcF9zZWNyZXQ7DQo+PiDCoMKg wqDCoMKgwqDCoMKgwqAgaG9zdF9rZXkgPSBjdHJsLT5ob3N0X2tleTsNCj4NCj4gT3RoZXIgdGhh biB0aGF0LCBmb3IgdGhpcyBhbmQgdGhlIG5leHQgb25lOg0KPg0KPiBSZXZpZXdlZC1ieTogU2Fn aSBHcmltYmVyZyA8c2FnaUBncmltYmVyZy5tZT4NCg0KdGhhbmtzIEknbGwgc2VuZCBvdXQgVjIg d2l0aCBmaXhlcyBhbmQgcmV2aWV3ZWQtYnkgdGFnLg0KDQotY2sNCg0KDQo=