From: Dongli Zhang <dongli.zhang@oracle.com>
To: Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me
Cc: axboe@kernel.dk, alan.adamson@oracle.com
Subject: Re: [PATCH] nvme: cancel requests for real
Date: Wed, 27 May 2020 12:36:07 -0700 [thread overview]
Message-ID: <eaccdf19-25ef-cf15-5183-dee97b964025@oracle.com> (raw)
In-Reply-To: <20200527190913.3461503-1-kbusch@kernel.org>
Hi Keith,
On 5/27/20 12:09 PM, Keith Busch wrote:
> Once the driver decides to cancel requests, the concept of those
> requests timing out should no longer exist. Since we can't stop fake
> timeouts from preventing a forced reclaim, continue completing the same
> request until the block layer isn't told to pretend that didn't happen.
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
> drivers/nvme/host/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index ba860efd250d..72e5973dda3a 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -310,7 +310,7 @@ bool nvme_cancel_request(struct request *req, void *data, bool reserved)
> return true;
>
> nvme_req(req)->status = NVME_SC_HOST_ABORTED_CMD;
> - blk_mq_complete_request(req);
> + while (!blk_mq_complete_request(req));
If the probability is configured to fail every time with 100% probability, we
would run into endless loop?
Dongli Zhang
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-05-27 19:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 19:09 [PATCH] nvme: cancel requests for real Keith Busch
2020-05-27 19:36 ` Dongli Zhang [this message]
2020-05-27 19:57 ` Keith Busch
2020-05-27 20:18 ` Sagi Grimberg
2020-05-27 20:39 ` Alan Adamson
2020-05-28 4:59 ` Christoph Hellwig
2020-05-28 4:58 ` Christoph Hellwig
2020-05-28 19:37 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaccdf19-25ef-cf15-5183-dee97b964025@oracle.com \
--to=dongli.zhang@oracle.com \
--cc=alan.adamson@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).