From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"hare@suse.de" <hare@suse.de>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvme-common: simplify nvme_auth_generate_key
Date: Mon, 9 Jan 2023 07:01:41 +0000 [thread overview]
Message-ID: <ebb946b0-9662-696f-c3e1-8cae2166b372@nvidia.com> (raw)
In-Reply-To: <20230108184123.393727-1-hch@lst.de>
On 1/8/23 10:41, Christoph Hellwig wrote:
> Return the key or NULL on success, and an ERR_PTR on failure
> instead of passing a separate ret_key argument to return the key.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Looks good,
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2023-01-09 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 18:41 [PATCH] nvme-common: simplify nvme_auth_generate_key Christoph Hellwig
2023-01-09 3:30 ` Jens Axboe
2023-01-09 7:01 ` Chaitanya Kulkarni [this message]
2023-01-09 9:37 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebb946b0-9662-696f-c3e1-8cae2166b372@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox