From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/3] nvme: improve the NVME_CONNECT_AUTHREQ* definitions
Date: Wed, 21 Sep 2022 08:13:04 +0200 [thread overview]
Message-ID: <ee3bbeaa-0ccf-e735-cc96-18e5ad8e96b0@suse.de> (raw)
In-Reply-To: <20220920171931.1289669-3-hch@lst.de>
On 9/20/22 19:19, Christoph Hellwig wrote:
> Mark them as unsigned so that we don't need extra casts, and define
> them relative to cdword0 instead of requiring extra shifts.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/nvme/target/fabrics-cmd.c | 6 ++----
> include/linux/nvme.h | 4 ++--
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
next prev parent reply other threads:[~2022-09-21 6:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 17:19 nvme fabrics authentication fixups Christoph Hellwig
2022-09-20 17:19 ` [PATCH 1/3] nvmet-auth: don't try to cancel a non-initialized work_struct Christoph Hellwig
2022-09-21 6:15 ` Hannes Reinecke
2022-09-21 9:23 ` Sagi Grimberg
2022-09-20 17:19 ` [PATCH 2/3] nvme: improve the NVME_CONNECT_AUTHREQ* definitions Christoph Hellwig
2022-09-21 6:13 ` Hannes Reinecke [this message]
2022-09-21 9:24 ` Sagi Grimberg
2022-09-20 17:19 ` [PATCH 3/3] nvmet: add helpers to set the result field for connect commands Christoph Hellwig
2022-09-21 6:14 ` Hannes Reinecke
2022-09-21 9:24 ` Sagi Grimberg
2022-09-21 6:10 ` nvme fabrics authentication fixups Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee3bbeaa-0ccf-e735-cc96-18e5ad8e96b0@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox