From: axboe@kernel.dk (Jens Axboe)
Subject: [4.18-rc2 regression] WARNING: CPU: 0 PID: 1 at drivers/nvme/host/pci.c:2570 nvme_probe+0x212/0x440
Date: Fri, 29 Jun 2018 08:52:18 -0600 [thread overview]
Message-ID: <eebd4ce8-ea4c-30e8-d53b-691f28af4286@kernel.dk> (raw)
In-Reply-To: <e1b1ed3e-e0f3-3e21-c924-40620e850774@kernel.dk>
On 6/29/18 7:54 AM, Jens Axboe wrote:
> On 6/29/18 3:16 AM, hch@lst.de wrote:
>>> static inline struct scatterlist *__sg_next(struct scatterlist *sg)
>>> {
>>> -#ifdef CONFIG_DEBUG_SG
>>> - BUG_ON(sg->sg_magic != SG_MAGIC);
>>> -#endif
>>> return sg_is_last(sg) ? NULL : ____sg_next(sg);
>>> }
>>
>> All that sg mess in i915 really needs to switch to using the generic
>> helpers instead of being opencoded..
>
> Totally agreed...
>
>> But except for that the sg_magic removal looks good to me:
>>
>> Acked-by: Christoph Hellwig <hch at lst.de>
>
> Thanks, though I wonder if we can sneak this into 4.18. I'd rather
> avoid having to shrink nvme segment count further, if at all possible.
Decided I'll see what the boss man says, it's small enough that it
should be doable... Queued up for 4.18.
--
Jens Axboe
prev parent reply other threads:[~2018-06-29 14:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-24 20:37 [4.18-rc2 regression] WARNING: CPU: 0 PID: 1 at drivers/nvme/host/pci.c:2570 nvme_probe+0x212/0x440 Jordan Glover
2018-06-24 21:15 ` Scott Bauer
2018-06-24 22:06 ` Jordan Glover
2018-06-25 3:13 ` Jens Axboe
2018-06-25 11:13 ` Jordan Glover
2018-06-25 13:52 ` Jens Axboe
2018-06-25 15:01 ` Jordan Glover
2018-06-29 9:16 ` hch
2018-06-29 13:54 ` Jens Axboe
2018-06-29 14:52 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eebd4ce8-ea4c-30e8-d53b-691f28af4286@kernel.dk \
--to=axboe@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox