From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B35AAC46CCD for ; Tue, 19 Dec 2023 11:59:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zRZTfMJl5C7xdAtnUeUo0z8eB6SUbLVOKctuKxplhSk=; b=i8NAJIW+7ZLOLQCbVI0WTpdRLo CNMLurpMuQpAP2FJbA+ZXIEyV9qYZwi19iXYoFtKI7a0LdgqGg0cVbamiv45SNxl0ldGRWqHeMp0c RxvvPyoDXExZRHTlJuYdjQfWltl/dYf4sFhpEEB6FzIU/3eHr1VLiYcVMI7d5hox2hrX4KOVJ03ho MMLOW5yCl9hNA6OU5F2TFJs90uQPdTqcYqySC7Ch+Zngb8D1EYlBNMZzEj5tzij+q7AsiiYjetT2z QWxHrOTthG2RaLBnDjeQiewBcon2s6E6L9JEvgiwm8MEp6eGoO+7GQXcffEonKqX5ukOhpb7vBefe AAN/YCdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFYl5-00DwJ7-2c; Tue, 19 Dec 2023 11:59:35 +0000 Received: from smtp-out1.suse.de ([195.135.223.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFYl1-00DwGA-1r for linux-nvme@lists.infradead.org; Tue, 19 Dec 2023 11:59:33 +0000 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2C1FD221F9; Tue, 19 Dec 2023 11:59:30 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8B0671375D; Tue, 19 Dec 2023 11:59:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id IBz1HqGFgWV1OgAAD6G6ig (envelope-from ); Tue, 19 Dec 2023 11:59:29 +0000 Message-ID: Date: Tue, 19 Dec 2023 12:59:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 6/6] nvme: repack struct nvme_ns_head Content-Language: en-US To: Daniel Wagner , linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Keith Busch , Christoph Hellwig , Sagi Grimberg , Max Gurtovoy , Chaitanya Kulkarni References: <20231218165954.29652-1-dwagner@suse.de> <20231218165954.29652-7-dwagner@suse.de> From: Hannes Reinecke In-Reply-To: <20231218165954.29652-7-dwagner@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; none X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Queue-Id: 2C1FD221F9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231219_035932_014104_76C9F478 X-CRM114-Status: GOOD ( 10.05 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 12/18/23 17:59, Daniel Wagner wrote: > ns_id, lba_shift and ms are always accessed for every read/write I/O in > nvme_setup_rw. By grouping these variables into one cacheline we can > safe some cycles. > > 4k sequential reads: > > baseline patched > Bandwidth: 1620 1634 > IOPs 66345579 66910939 > > Reviewed-by: Christoph Hellwig > Reviewed-by: Sagi Grimberg > Signed-off-by: Daniel Wagner > --- > drivers/nvme/host/nvme.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald, Werner Knoblich