From: James Smart <jsmart2021@gmail.com>
To: Sagi Grimberg <sagi@grimberg.me>, linux-nvme@lists.infradead.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] nvme-fc: clear q_live at beginning of association teardown
Date: Thu, 13 May 2021 11:47:56 -0700 [thread overview]
Message-ID: <f26aad29-aef7-6fd9-979b-a0bfc4f46a06@gmail.com> (raw)
In-Reply-To: <601fa5a1-e52b-edf1-f32e-b1c454e23758@grimberg.me>
On 5/12/2021 4:03 PM, Sagi Grimberg wrote:
>
>> The __nvmf_check_ready() routine used to bounce all filesystem io if
>> the controller state isn't LIVE. However, a later patch changed the
>> logic so that it rejection ends up being based on the Q live check.
>> The fc transport has a slightly different sequence from rdma and tcp
>> for shutting down queues/marking them non-live. FC marks its queue
>> non-live after aborting all ios and waiting for their termination,
>> leaving a rather large window for filesystem io to continue to hit the
>> transport. Unfortunately this resulted in filesystem io or applications
>> seeing I/O errors.
>>
>> Change the fc transport to mark the queues non-live at the first
>> sign of teardown for the association (when i/o is initially terminated).
>
> Sounds like the correct behavior to me, what is the motivation for doing
> that only after all I/O was aborted?
>
> And,
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
source evolution over time (rdma/tcp changed how they worked) and the
need didn't show up earlier based on the earlier checks.
-- james
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-05-13 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 4:56 [PATCH] nvme-fc: clear q_live at beginning of association teardown James Smart
2021-05-12 23:03 ` Sagi Grimberg
2021-05-13 18:47 ` James Smart [this message]
2021-05-13 19:59 ` Sagi Grimberg
2021-05-13 14:42 ` Himanshu Madhani
2021-05-14 9:20 ` Hannes Reinecke
2021-05-19 6:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f26aad29-aef7-6fd9-979b-a0bfc4f46a06@gmail.com \
--to=jsmart2021@gmail.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox