From: alan.adamson@oracle.com
To: Chaitanya Kulkarni <kch@nvidia.com>
Cc: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-core: fix comment to reflect right functions
Date: Mon, 5 Feb 2024 16:37:28 -0800 [thread overview]
Message-ID: <f4114934-b495-4718-b494-4b74ab1a00a0@oracle.com> (raw)
In-Reply-To: <20240206003021.6422-1-kch@nvidia.com>
Reviewed-by: Alan Adamson <alan.adamson@oracle.com>
On 2/5/24 4:30 PM, Chaitanya Kulkarni wrote:
> The functions and the attribute listed in the comment doesn't exists in
> the code, (ns->logging_enabled, nvme_passthru_err_log_enabled_store()
> and nvme_passthru_err_log_enabled_show())
>
> Update the comment with right function names and a comment
> ns->passthru_err_log_enabled, nvme_io_passthru_err_log_enabled_store()
> and nvme_io_passthru_err_log_enabled_show().
>
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
> ---
> drivers/nvme/host/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 975245527c1f..7db700b2ed00 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -3762,8 +3762,8 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, struct nvme_ns_info *info)
>
> /*
> * Set ns->disk->device->driver_data to ns so we can access
> - * ns->logging_enabled in nvme_passthru_err_log_enabled_store() and
> - * nvme_passthru_err_log_enabled_show().
> + * ns->passthru_err_log_enabled in
> + * nvme_io_passthru_err_log_enabled_[store | show]().
> */
> dev_set_drvdata(disk_to_dev(ns->disk), ns);
>
next prev parent reply other threads:[~2024-02-06 0:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 0:30 [PATCH] nvme-core: fix comment to reflect right functions Chaitanya Kulkarni
2024-02-06 0:37 ` alan.adamson [this message]
2024-02-07 18:40 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4114934-b495-4718-b494-4b74ab1a00a0@oracle.com \
--to=alan.adamson@oracle.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox