Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@linux.dev>
To: Christoph Hellwig <hch@lst.de>, Adrian Huang12 <ahuang12@lenovo.com>
Cc: "kbusch@kernel.org" <kbusch@kernel.org>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Jiwei JW10 Sun <sunjw10@lenovo.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>
Subject: Re: [External] Re: [PATCH] Revert "nvme-pci: clamp max_hw_sectors based on DMA optimized limitation"
Date: Thu, 15 Oct 2026 11:30:49 +0100	[thread overview]
Message-ID: <f4f48392-4181-456e-b3d7-907a30b13825@linux.dev> (raw)
In-Reply-To: <8894307f-1042-497c-9c16-3fc1312486fb@linux.dev>

On 10/12/26 15:39, John Garry wrote:
> On 10/12/26 13:17, Christoph Hellwig wrote:
>> On Mon, Oct 12, 2026 at 09:42:04AM +0100, John Garry wrote:
>>> And now we seem to have a conflict, as Christoph wants block size > IOVA
>>> rcache limit but you find it may cause this soft lockup.
>>>
>>>> 2. Another NVME with mdts=5 (maximum data transfer size = 128KB)
>>>>     2.1 The issue does not reproduce regardless of the 'bs' 
>>>> configuration
>>>> 3. The condition '128 KB' is identified because the IOMMU scalable 
>>>> IOVA mechanism supports a maximum transfer size of 128 KB.
>>>> 4. IOMMU pass-through mode does not trigger the issue with the 
>>>> 'mdts=10' nvme disk.
>>>> 5. The issue only appears with high-core-count servers
>>>>     5.1 Reproduced servers: 448-core server and 384-core server
>>>>     5.2 Non-reproduced server: 128-core server
>>>
>>> How long does it take for the lockup to trigger? Pretty quickly, I 
>>> guess.
>>>
>>> Does changing the number of CPUs affect throughput (before the 
>>> lockup)? Are
>>> you using just a single disk?
>>
>> If the iova cache locks up under a perfectly normal workloads it
>> is broken. 
> 
> 
>> We really need to fix the code there.
> 
> Sure, but it would help to first fully understand the conditions to fix it.

BTW, @Adrian, it would be good to run your test with the IOMMU in strict 
mode as well, just to give an idea if there is a problem there as well.


  reply	other threads:[~2026-10-15 10:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 12:02 [PATCH] Revert "nvme-pci: clamp max_hw_sectors based on DMA optimized limitation" Christoph Hellwig
2026-10-08  7:36 ` John Garry
2026-10-08 12:37   ` Christoph Hellwig
2026-10-09  9:11     ` [External] " Adrian Huang12
2026-10-09 15:37       ` Keith Busch
2026-10-12  8:42       ` John Garry
2026-10-12 12:17         ` Christoph Hellwig
2026-10-12 14:39           ` John Garry
2026-10-15 10:30             ` John Garry [this message]
2026-10-15 12:49 ` Hans Holmberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4f48392-4181-456e-b3d7-907a30b13825@linux.dev \
    --to=john.garry@linux.dev \
    --cc=ahuang12@lenovo.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux.dev \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=sunjw10@lenovo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox