From: Sagi Grimberg <sagi@grimberg.me>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <kch@nvidia.com>,
Daniel Wagner <dwagner@suse.de>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH 3/6] nvme: add per request retry timer
Date: Sun, 6 Sep 2026 03:09:14 +0300 [thread overview]
Message-ID: <f6fc10fd-4e45-4127-b43f-51e66e15f347@grimberg.me> (raw)
In-Reply-To: <20260902134156.GC21649@lst.de>
On 02/09/2026 16:41, Christoph Hellwig wrote:
> On Sun, Aug 23, 2026 at 11:48:59AM +0300, Sagi Grimberg wrote:
>> The existing command retry mechanism adds a request to retry
>> to a retry list and modifies a request-queue (controller) wide
>> dealyed queue timer.
>>
>> The issue is that the existing requests in this queue may wait
>> for longer periods of time as more requests are completed with
>> a retry crd level.
>>
>> Instead, add a per-request timer that will allow different
>> requests retry in a way that is independent of other requests.
> This blows every nvme_request. I think we'd only need a per-CRD
> level retry list and timer, can't we do that instead?
I can't see how, because we'd be modifying the timer potentially
indefinitely while
requests are pending....
I understand that this bloats the nvme_request, however this is not
accessed in the hot path.
next prev parent reply other threads:[~2026-09-06 0:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-23 8:48 [PATCH 0/6] Support per command retry timer Sagi Grimberg
2026-08-23 8:48 ` [PATCH 1/6] nvme-mpath: No need to protect req->bio with requeue_lock Sagi Grimberg
2026-08-24 11:31 ` Hannes Reinecke
2026-08-24 15:53 ` John Garry
2026-09-02 13:39 ` Christoph Hellwig
2026-08-23 8:48 ` [PATCH 2/6] nvme: add nvme_crd_msecs helper Sagi Grimberg
2026-08-24 11:32 ` Hannes Reinecke
2026-09-02 13:40 ` Christoph Hellwig
2026-09-06 0:07 ` Sagi Grimberg
2026-08-23 8:48 ` [PATCH 3/6] nvme: add per request retry timer Sagi Grimberg
2026-08-24 13:25 ` Hannes Reinecke
2026-09-02 13:41 ` Christoph Hellwig
2026-09-06 0:09 ` Sagi Grimberg [this message]
2026-09-11 22:53 ` Sagi Grimberg
2026-08-23 8:49 ` [PATCH 4/6] nvme-mpath: support controller crd when failing over request Sagi Grimberg
2026-08-24 13:45 ` Hannes Reinecke
2026-08-24 14:23 ` Sagi Grimberg
2026-09-02 13:43 ` Christoph Hellwig
2026-09-06 0:15 ` Sagi Grimberg
2026-08-23 8:49 ` [PATCH 5/6] nvmet: Add support for configurable crdt (command retry delay) attributes Sagi Grimberg
2026-09-02 13:44 ` Christoph Hellwig
2026-09-06 0:20 ` Sagi Grimberg
2026-08-23 8:49 ` [PATCH 6/6] nvme/fault-injection: Support for error injection with custom crd Sagi Grimberg
2026-08-23 8:49 ` [PATCH 7/6 RFC] nvme: test per-command retry delay Sagi Grimberg
2026-08-30 8:23 ` Shin'ichiro Kawasaki
2026-08-30 20:55 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6fc10fd-4e45-4127-b43f-51e66e15f347@grimberg.me \
--to=sagi@grimberg.me \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox