From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Casey Chen <cachen@purestorage.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"yzhong@purestorage.com" <yzhong@purestorage.com>,
"sconnor@purestorage.com" <sconnor@purestorage.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"mkhalfella@purestorage.com" <mkhalfella@purestorage.com>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH 1/1] nvme: fix use-after-free of admin queue via stale pointer
Date: Fri, 31 Oct 2025 08:16:09 +0000 [thread overview]
Message-ID: <fa540874-6d3d-4927-a51c-1488593c8d3d@nvidia.com> (raw)
In-Reply-To: <aQQk6nWYeB71PBK_@kbusch-mbp>
On 10/30/25 19:54, Keith Busch wrote:
> On Thu, Oct 30, 2025 at 08:12:53AM +0000, Chaitanya Kulkarni wrote:
>> On 10/29/25 17:39, Keith Busch wrote:
>> I've added required comments that are very much needed here,
>> totally untested :-
> Honestly that seems a bit verbose. The code mostly speaks for itself
> with this move: the controller's request_queue reference remains active
> as long as there's an active controller reference.
whatever works for everyone :).
-ck
next prev parent reply other threads:[~2025-10-31 8:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 21:08 [PATCH 0/1] cover letter Casey Chen
2025-10-29 21:08 ` [PATCH 1/1] nvme: fix use-after-free of admin queue via stale pointer Casey Chen
2025-10-29 23:00 ` Chaitanya Kulkarni
2025-10-29 23:33 ` Ming Lei
2025-10-30 0:39 ` Keith Busch
2025-10-30 8:12 ` Chaitanya Kulkarni
2025-10-31 2:54 ` Keith Busch
2025-10-31 8:16 ` Chaitanya Kulkarni [this message]
2025-10-31 19:19 ` Casey Chen
2025-10-31 19:31 ` Chaitanya Kulkarni
2025-11-04 22:39 ` Casey Chen
2025-11-04 23:00 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa540874-6d3d-4927-a51c-1488593c8d3d@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=cachen@purestorage.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=mkhalfella@purestorage.com \
--cc=sconnor@purestorage.com \
--cc=yzhong@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox