From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 896C5CD13CF for ; Mon, 2 Sep 2024 13:53:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qCAWccdUbVFfRk9YDDEmksSbeL0vVojk58srJkBL0v4=; b=n4ukqIuR4NGxPTsKMh66ZjD261 rnc4DXI29yFXir+8qjbBh9BHKGCxLCUBgJJ+NPOH051g0TXTEd/ndL8ut+8vXertODMiYlMWoBLic ZTw779jgE5/XqicgSOHtNNj+VxO6IBWf6Bv9ot0zd0pd3/OfM/MZaDV3uVB/9wc9lcVfTssA5Up47 yPDSGZfnOSOegE3J2lnsLANbWuoKETks8sCsVaZYTpujZ+GuAymBlkEAkGfADe8WAgHmpxIJ2AHBC hHywbZVXfP+pCLSmuwGDX4x15rYjOuXOkgxzixcdGcM1zOanvi9Nglxr7ck556cDENjyF9lJNLddP 72z7q8ig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sl7UR-0000000EYdh-2UwP; Mon, 02 Sep 2024 13:53:07 +0000 Received: from smtp-out1.suse.de ([195.135.223.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sl7UO-0000000EYck-2Mhx for linux-nvme@lists.infradead.org; Mon, 02 Sep 2024 13:53:06 +0000 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 35A82219A6; Mon, 2 Sep 2024 13:53:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1725285181; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qCAWccdUbVFfRk9YDDEmksSbeL0vVojk58srJkBL0v4=; b=sdJRRD30ESfyOEaPKriII3WhIU+0NMRi3uINbmjfeYn3skKJJ8F3MaxzIEKGGdu5/dhMvg PSxLBZh4JwRqwV+RYlSD1aYP9pur9FZhb7R+Nf0t/V89iN7uUEsAhR0CIY8na9nTBQ2wpX EQpghivvcMb7FCkyOe7j8Xd/BZv4riM= Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.com header.s=susede1 header.b=sdJRRD30 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1725285181; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qCAWccdUbVFfRk9YDDEmksSbeL0vVojk58srJkBL0v4=; b=sdJRRD30ESfyOEaPKriII3WhIU+0NMRi3uINbmjfeYn3skKJJ8F3MaxzIEKGGdu5/dhMvg PSxLBZh4JwRqwV+RYlSD1aYP9pur9FZhb7R+Nf0t/V89iN7uUEsAhR0CIY8na9nTBQ2wpX EQpghivvcMb7FCkyOe7j8Xd/BZv4riM= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E82B913A7C; Mon, 2 Sep 2024 13:53:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id hEqPNjzD1WZPKgAAD6G6ig (envelope-from ); Mon, 02 Sep 2024 13:53:00 +0000 Message-ID: Subject: Re: [PATCH v2 3/3] nvme: add test for controller rescan under I/O load From: Martin Wilck To: Shinichiro Kawasaki Cc: Nilay Shroff , Daniel Wagner , Chaitanya Kulkarni , Hannes Reinecke , "linux-block@vger.kernel.org" , "linux-nvme@lists.infradead.org" Date: Mon, 02 Sep 2024 15:53:00 +0200 In-Reply-To: <57yxf7o7zcp4j34cfgk3glhmfag4ukvedzqgtr7fbqdmy2gvsq@t573offeg3kg> References: <20240823200822.129867-1-mwilck@suse.com> <20240823200822.129867-3-mwilck@suse.com> <57yxf7o7zcp4j34cfgk3glhmfag4ukvedzqgtr7fbqdmy2gvsq@t573offeg3kg> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 MIME-Version: 1.0 X-Rspamd-Queue-Id: 35A82219A6 X-Spamd-Result: default: False [-6.51 / 50.00]; BAYES_HAM(-3.00)[99.98%]; DWL_DNSWL_MED(-2.00)[suse.com:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:dkim,suse.com:mid]; DKIM_TRACE(0.00)[suse.com:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240902_065304_815286_2C243A82 X-CRM114-Status: GOOD ( 10.17 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, 2024-08-29 at 07:36 +0000, Shinichiro Kawasaki wrote: > Shellcheck reports a warning here: >=20 > =C2=A0 tests/nvme/053:47:9: warning: Prefer mapfile or read -a to split > command output (or quote to avoid splitting). [SC2207] >=20 > It is a bit lengthy, but let's replace the line above with this: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 while read -r line ; do ctrls+= =3D("$line"); done < > <(_nvme_get_ctrl_list) Thanks for the review. If you don't mind, I'll just use "mapfile -t", as suggested by shellcheck. Martin