Re: [PATCHv4 0/2] nvme: fix system fault observed while shutting down controller

[Nilay Shroff <nilay@linux.ibm.com>]

Hi Keith,

On 11/5/24 23:05, Keith Busch wrote:
> On Tue, Nov 05, 2024 at 11:42:07AM +0530, Nilay Shroff wrote:
>> This patch series addresses the system fault observed while shutting down 
>> fabric controller. We already fixed it[1] earlier however it was later 
>> relaized that we do have a better and optimal way to address it [2].
>>
>> The first patch in the series reverts the changes implemented in [3].
>> So essentially we're making keep-alive operation asynchronous again as 
>> it was earlier.
>>
>> The second patch in the series fix the kernel crash observed while 
>> shutting down fabric controller. The system fault was observed due 
>> to the keep-alive request sneaking in while shutting down fabric 
>> controller. We encounter the below intermittent kernel crash while 
>> running blktest nvme/037:
> 
> Thanks, this all looks good to me. I think Sagi had reviewed patch 2
> already, but I'll wait a day or two before queuing this up in case he
> has any last minute comments.

Just wanted to check, did you get a chance to queue this up?

Thanks,
--Nilay