From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66C85C02195 for ; Wed, 29 Jan 2025 17:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:Cc:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dNRZE1wRPI3+cVzpq2MiJyQrXak+KjxySL05qBZwi3I=; b=w91A1zteMHsKh+K0JZsu+x9Hw7 EMfuAUeijg1Zrx6/SWrQQZOiHtWp8UXJyRawwRkoe5oszzfFjTEJkYdiRMrf2g7YNcDZ9HiAdB95f zm2+zIrCrgzH2vh1rHJoE+ZfKE+HJ1zbdV+zNy0LZBLdAu2kGbdFY/yLQ2X09PXOQczFiboThA46X ft7Zwq4VltpX8nZgPwpwI/vw/w9NEQ35DPkixYbRDOB0HrtyvC/oao7NhKrNAOPz5ICDU7iMNC5vD ApXqsUzmnf2Zd4yTaJIn65HvliEAfdCeZrowz3waWnNRbLwBrGatm6L0b+u0oatK6b1s2H4aCD1Ri u7xf7SWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdC17-00000007VZc-2yEZ; Wed, 29 Jan 2025 17:38:21 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdBbv-00000007SYh-1NqR; Wed, 29 Jan 2025 17:12:20 +0000 Received: from [100.65.130.94] (unknown [20.236.10.163]) by linux.microsoft.com (Postfix) with ESMTPSA id B361C203F2DF; Wed, 29 Jan 2025 09:12:15 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B361C203F2DF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1738170737; bh=dNRZE1wRPI3+cVzpq2MiJyQrXak+KjxySL05qBZwi3I=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=KF5CYJEMAg7wD96ahKvWhkAFA05d2EUsKiRjXm+SrhlcieyjVvtYaExuKNZLJq+g2 aBFGl/Q/OmH+pg7BhR5kfVvugzt2v4vFfmJ8RuG1opp/VMgS23ja3qFHYzfub/yGXl hPpNsGrrOx1WOoNEIOcsOUJA+IETCxANclm3bUSY= Message-ID: Date: Wed, 29 Jan 2025 09:12:18 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: eahariha@linux.microsoft.com, Andrew Morton , Yaron Avizrat , Oded Gabbay , Julia Lawall , Nicolas Palix , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Jaroslav Kysela , Takashi Iwai , Chris Mason , Josef Bacik , David Sterba , Ilya Dryomov , Dongsheng Yang , Jens Axboe , Xiubo Li , Damien Le Moal , Niklas Cassel , Carlos Maiolino , "Darrick J. Wong" , Sebastian Reichel , Keith Busch , Christoph Hellwig , Sagi Grimberg , Frank Li , Mark Brown , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Shyam Sundar S K , Hans de Goede , Henrique de Moraes Holschuh , Selvin Xavier , Kalesh AP , Jason Gunthorpe , Leon Romanovsky , cocci@inria.fr, LKML , linux-scsi@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sound@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-xfs@vger.kernel.org, linux-pm@vger.kernel.org, linux-nvme@lists.infradead.org, linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, platform-driver-x86@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, linux-rdma@vger.kernel.org Subject: Re: [PATCH 14/16] platform/x86/amd/pmf: convert timeouts to secs_to_jiffies() To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= References: <20250128-converge-secs-to-jiffies-part-two-v1-0-9a6ecf0b2308@linux.microsoft.com> <20250128-converge-secs-to-jiffies-part-two-v1-14-9a6ecf0b2308@linux.microsoft.com> From: Easwar Hariharan Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250129_091219_424583_47E08DDE X-CRM114-Status: GOOD ( 16.72 ) X-Mailman-Approved-At: Wed, 29 Jan 2025 09:38:17 -0800 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 1/29/2025 5:12 AM, Ilpo Järvinen wrote: > On Tue, 28 Jan 2025, Easwar Hariharan wrote: > >> Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced >> secs_to_jiffies(). As the value here is a multiple of 1000, use >> secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. >> >> This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with >> the following Coccinelle rules: >> >> @depends on patch@ >> expression E; >> @@ >> >> -msecs_to_jiffies >> +secs_to_jiffies >> (E >> - * \( 1000 \| MSEC_PER_SEC \) >> ) >> >> Signed-off-by: Easwar Hariharan >> --- >> drivers/platform/x86/amd/pmf/acpi.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/platform/x86/amd/pmf/acpi.c b/drivers/platform/x86/amd/pmf/acpi.c >> index dd5780a1d06e1dc979fcff5bafd6729bc4937eab..6b7effe80b78b7389b320ee65fa5d2373f782a2f 100644 >> --- a/drivers/platform/x86/amd/pmf/acpi.c >> +++ b/drivers/platform/x86/amd/pmf/acpi.c >> @@ -220,7 +220,8 @@ static void apmf_sbios_heartbeat_notify(struct work_struct *work) >> if (!info) >> return; >> >> - schedule_delayed_work(&dev->heart_beat, msecs_to_jiffies(dev->hb_interval * 1000)); >> + schedule_delayed_work(&dev->heart_beat, >> + secs_to_jiffies(dev->hb_interval)); >> kfree(info); >> } > > Hi, > > So you made the line shorter but still added the newline char for some > reason even if the original didn't have one?? Please don't enforce 80 > chars limit with patches like this. > Sorry about that, I can fix that in v2. Thanks for the review! - Easwar (he/him)