Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: John Meneghini <jmeneghi@redhat.com>, martin.petersen@oracle.com
Cc: axboe@kernel.dk, bgurney@redhat.com, emilne@redhat.com,
	gustavoars@kernel.org, hare@suse.de, hch@lst.de,
	james.smart@broadcom.com, kbusch@kernel.org, kees@kernel.org,
	linux-hardening@vger.kernel.org, linux-nvme@lists.infradead.org,
	linux-scsi@vger.kernel.org, njavali@marvell.com,
	sagi@grimberg.me
Subject: Re: [PATCH] Revert "scsi: qla2xxx: Fix memcpy() field-spanning write issue"
Date: Thu, 25 Sep 2025 15:38:37 +0200	[thread overview]
Message-ID: <fcdb0a83-3b1c-42bd-b58b-b501cfbf27fa@embeddedor.com> (raw)
In-Reply-To: <20250925130729.776904-1-jmeneghi@redhat.com>



On 9/25/25 15:07, John Meneghini wrote:
> This reverts commit 6f4b10226b6b1e7d1ff3cdb006cf0f6da6eed71e.
> 
> We've been testing this patch and it turns out there is a significant
> bug here. This leaks memory and causes a driver hang.
> 
> Link:
> https://lore.kernel.org/linux-scsi/yq1zfajqpec.fsf@ca-mkp.ca.oracle.com/

Thanks for the report. I wonder if you have any logs or something I could
look at to figure out what's going on.

Bryan,

Could you please share how this patch[1] was tested?

Thanks
-Gustavo

[1] https://lore.kernel.org/linux-scsi/20250813200744.17975-10-bgurney@redhat.com/



  reply	other threads:[~2025-09-25 13:40 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13 20:07 [PATCH v9 0/8] nvme-fc: FPIN link integrity handling Bryan Gurney
2025-08-13 20:07 ` [PATCH v9 1/9] fc_els: use 'union fc_tlv_desc' Bryan Gurney
2025-08-13 20:07 ` [PATCH v9 2/9] nvme: add NVME_CTRL_MARGINAL flag Bryan Gurney
2025-08-18 12:07   ` Hannes Reinecke
2025-08-13 20:07 ` [PATCH v9 3/9] nvme-fc: marginal path handling Bryan Gurney
2025-08-13 20:07 ` [PATCH v9 4/9] nvme-fc: nvme_fc_fpin_rcv() callback Bryan Gurney
2025-08-13 20:07 ` [PATCH v9 5/9] lpfc: enable FPIN notification for NVMe Bryan Gurney
2025-08-13 20:07 ` [PATCH v9 6/9] qla2xxx: " Bryan Gurney
2025-08-13 20:07 ` [PATCH v9 7/9] nvme: sysfs: emit the marginal path state in show_state() Bryan Gurney
2025-08-13 20:07 ` [PATCH v9 8/9] nvme-multipath: queue-depth support for marginal paths Bryan Gurney
2025-08-18 12:08   ` Hannes Reinecke
2025-08-13 20:07 ` [PATCH v9 9/9] scsi: qla2xxx: Fix memcpy field-spanning write issue Bryan Gurney
2025-08-18 12:09   ` Hannes Reinecke
2025-08-20  2:13   ` Martin K. Petersen
2025-08-20  2:18 ` [PATCH v9 0/8] nvme-fc: FPIN link integrity handling Martin K. Petersen
2025-08-26  2:33 ` (subset) " Martin K. Petersen
2025-09-23 19:21   ` John Meneghini
2025-09-25  1:43     ` Martin K. Petersen
2025-09-25 13:07       ` [PATCH] Revert "scsi: qla2xxx: Fix memcpy() field-spanning write issue" John Meneghini
2025-09-25 13:38         ` Gustavo A. R. Silva [this message]
2025-09-25 14:18           ` John Meneghini
2025-09-25 14:30             ` Gustavo A. R. Silva
2025-09-25 17:02             ` [PATCH RFC] scsi: qla2xxx: zero default_item last in qla24xx_free_purex_item Bryan Gurney
     [not found]               ` <e58d743b-a999-4e00-8f2e-31707744c5bb@embeddedor.com>
2025-09-25 18:43                 ` Bryan Gurney
2025-09-25 18:54                   ` Gustavo A. R. Silva
2025-09-25 18:57         ` [PATCH] Revert "scsi: qla2xxx: Fix memcpy() field-spanning write issue" Gustavo A. R. Silva
2025-09-30  9:35           ` John Meneghini
2025-09-30 20:13             ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcdb0a83-3b1c-42bd-b58b-b501cfbf27fa@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=axboe@kernel.dk \
    --cc=bgurney@redhat.com \
    --cc=emilne@redhat.com \
    --cc=gustavoars@kernel.org \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.smart@broadcom.com \
    --cc=jmeneghi@redhat.com \
    --cc=kbusch@kernel.org \
    --cc=kees@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=njavali@marvell.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox