From: Mikulas Patocka <mpatocka@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "Ming Lei" <tom.leiming@gmail.com>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
"Jan Kara" <jack@suse.cz>, "Vlastimil Babka" <vbabka@suse.cz>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Matthew Wilcox" <willy@infradead.org>,
"Michal Hocko" <mhocko@suse.com>,
stable@vger.kernel.org, regressions@lists.linux.dev,
"Alasdair Kergon" <agk@redhat.com>,
"Mike Snitzer" <snitzer@kernel.org>,
dm-devel@lists.linux.dev, linux-mm@kvack.org,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
ming.lei@redhat.com
Subject: Re: Intermittent storage (dm-crypt?) freeze - regression 6.4->6.5
Date: Wed, 1 Nov 2023 13:16:37 +0100 (CET) [thread overview]
Message-ID: <fd2e3ba-d681-4856-3d50-9f63a2fcb0a8@redhat.com> (raw)
In-Reply-To: <ab02413f-4bf2-4d92-baf7-62fbd106f5df@suse.de>
On Wed, 1 Nov 2023, Hannes Reinecke wrote:
> And that is something I've been wondering (for quite some time now):
> What _is_ the appropriate error handling for -ENOMEM?
> At this time, we assume it to be a retryable error and re-run the queue
> in the hope that things will sort itself out.
> But if they don't we're stuck.
> Can we somehow figure out if we make progress during submission, and (at
> least) issue a warning once we detect a stall?
The appropriate way is to use mempools. mempool_alloc (with
__GFP_DIRECT_RECLAIM) can't ever fail.
But some kernel code does GFP_NOIO allocations in the I/O path and the
authors hope that they get away with it.
Mikulas
prev parent reply other threads:[~2023-11-01 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ZT+wDLwCBRB1O+vB@mail-itl>
[not found] ` <a2a8dbf6-d22e-65d0-6fab-b9cdf9ec3320@redhat.com>
[not found] ` <20231030155603.k3kejytq2e4vnp7z@quack3>
[not found] ` <ZT/e/EaBIkJEgevQ@mail-itl>
[not found] ` <98aefaa9-1ac-a0e4-fb9a-89ded456750@redhat.com>
[not found] ` <ZUB5HFeK3eHeI8UH@mail-itl>
[not found] ` <20231031140136.25bio5wajc5pmdtl@quack3>
[not found] ` <ZUEgWA5P8MFbyeBN@mail-itl>
[not found] ` <CACVXFVOEWDyzasS7DWDvLOhC3Hr6qOn5ks3HLX+fbRYCxYv26w@mail.gmail.com>
[not found] ` <ZUG0gcRhUlFm57qN@mail-itl>
2023-11-01 3:24 ` Intermittent storage (dm-crypt?) freeze - regression 6.4->6.5 Ming Lei
2023-11-01 10:15 ` Hannes Reinecke
2023-11-01 10:26 ` Jan Kara
2023-11-01 11:23 ` Ming Lei
2023-11-02 14:02 ` Keith Busch
2023-11-01 12:16 ` Mikulas Patocka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd2e3ba-d681-4856-3d50-9f63a2fcb0a8@redhat.com \
--to=mpatocka@redhat.com \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dm-devel@lists.linux.dev \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marmarek@invisiblethingslab.com \
--cc=mhocko@suse.com \
--cc=ming.lei@redhat.com \
--cc=regressions@lists.linux.dev \
--cc=snitzer@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tom.leiming@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox