Re: [PATCH v5 2/5] fcntl: rename rw_hint_* to rw_lifetime_hint_*

Kanchan Joshi
2024-09-12T15:52:00Z

On 9/12/2024 6:24 PM, Christoph Hellwig wrote:
> On Tue, Sep 10, 2024 at 08:31:57PM +0530, Kanchan Joshi wrote:
>> F_GET/SET_RW_HINT fcntl handlers query/set write life hints.
>> Rename the handlers/helpers to be explicit that write life hints are
>> being handled.
>>
>> This is in preparation to introduce a new interface that supports more
>> than one type of write hint.
>
> Wouldn't it make more sense to stick with the name as exposed in the
> uapi?

uapi used
for opcode: F_GET/SET_RW_HINT
for values: RWH_WRITE_LIFE_*.

The kernel handlers were using the name rw_hint_* (e.g., rw_hint_valid,
fcntl_get/set_rw_hint etc.). Since rw_hint is generic term, it seemed
clearer to call a spade a spade (e.g. rw_lifetime_hint_valid,
fcntl_get/set_lifetime_hint).

The same minda applies to the previous patch - in fact IFF we
> decide to do the rename I'd probably expect both parts to go together.
>

Sure. I can merge both the patches if that's what you prefer.