From: james.smart@broadcom.com (James Smart)
Subject: [PATCH] nvme-fabrics: Ignore nr_io_queues option for discovery controllers
Date: Fri, 2 Mar 2018 10:02:22 -0800 [thread overview]
Message-ID: <fe33ec1c-1425-fd63-65bb-e583eb123b81@broadcom.com> (raw)
In-Reply-To: <20180302174501.31228-1-roland@kernel.org>
On 3/2/2018 9:45 AM, Roland Dreier wrote:
> @@ -650,6 +650,11 @@ static int nvmf_parse_options(struct nvmf_ctrl_options *opts,
> ret = -EINVAL;
> goto out;
> }
> + if (opts->discovery_nqn) {
> + pr_warn("Ignoring nr_io_queues value for discovery controller\n");
> + break;
> + }
> +
> opts->nr_io_queues = min_t(unsigned int,
> num_online_cpus(), token);
> break;
a pr_warn is a bit verbose. even a pr_warn is. I'd prefer no message at
all as it's normal for a discovery controller.
-- james
next prev parent reply other threads:[~2018-03-02 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 17:45 [PATCH] nvme-fabrics: Ignore nr_io_queues option for discovery controllers Roland Dreier
2018-03-02 18:02 ` James Smart [this message]
2018-03-05 19:46 ` Sagi Grimberg
2018-03-05 19:54 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe33ec1c-1425-fd63-65bb-e583eb123b81@broadcom.com \
--to=james.smart@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox