From: Bart Van Assche <bvanassche@acm.org>
To: Damien Le Moal <damien.lemoal@wdc.com>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] nvme: Fix io_opt limit setting
Date: Wed, 13 May 2020 21:47:16 -0700 [thread overview]
Message-ID: <fed0df8c-3005-fbdd-c413-06fd7d174dee@acm.org> (raw)
In-Reply-To: <20200514015452.1055278-1-damien.lemoal@wdc.com>
On 2020-05-13 18:54, Damien Le Moal wrote:
> @@ -1848,7 +1847,8 @@ static void nvme_update_disk_info(struct gendisk *disk,
> */
> blk_queue_physical_block_size(disk->queue, min(phys_bs, atomic_bs));
> blk_queue_io_min(disk->queue, phys_bs);
> - blk_queue_io_opt(disk->queue, io_opt);
> + if (io_opt)
> + blk_queue_io_opt(disk->queue, io_opt);
The above change looks confusing to me. We want the NVMe driver to set
io_opt, so why only call blk_queue_io_opt() if io_opt != 0? That means
that the io_opt value will be left to any value set by the block layer
core if io_opt == 0 instead of properly being set to zero.
Thanks,
Bart.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-05-14 4:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 1:54 [PATCH] nvme: Fix io_opt limit setting Damien Le Moal
2020-05-14 3:29 ` Martin K. Petersen
2020-05-14 3:40 ` Keith Busch
2020-05-14 3:47 ` Damien Le Moal
2020-05-14 4:12 ` Keith Busch
2020-05-14 4:13 ` Damien Le Moal
2020-05-14 4:47 ` Bart Van Assche [this message]
2020-05-14 4:49 ` Damien Le Moal
2020-05-14 22:19 ` Martin K. Petersen
2020-05-14 6:11 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fed0df8c-3005-fbdd-c413-06fd7d174dee@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox