From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E59A606A320 for ; Sun, 8 Nov 2026 21:07:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=fr+UayhC; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=RayU/r54 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=xJqdmXaMRLuUjZRj45HBi9m9/SkDdkLEvmT6c6aPy9w=; b=fr+UayhCnpP4AGn7e9RRyaWw1g z+mEd91El1/WN0IcKNgZS4oy/P12O0RiN7MmW9A/sc/p95OTphV9yVEBhDCnt/55RXO8JzZx8DWNT p3ELeztsnDkLLhBpexGnllOWBbT6ukcPHBKZQe6IlKJ3pSqiXamyvhTJKHJY8XNc/DXG69H5lB5EP mDWpYJ/As0KjveAZ9r1cupQ0AU9G1KCf2x4WDLXEYEiLnDs13jtqORG8RIwRDdElESZsK8W6bp4Jy 1KtDryO2NoYUEcsK6B2BRP375oV+NtRLaNNDknQUHXadKqMVi/28VOQaeXem011OCAvnBT+t2z7WF iBPvkM9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xQA6h-0000000GfuT-0FAN; Sun, 08 Nov 2026 21:07:19 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xQA6g-0000000GfuA-08kb for linux-nvme@lists.infradead.org; Sun, 08 Nov 2026 21:07:18 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B8DA143356; Sun, 8 Nov 2026 21:07:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EF7D1F0089F; Sun, 8 Nov 2026 21:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794172037; bh=xJqdmXaMRLuUjZRj45HBi9m9/SkDdkLEvmT6c6aPy9w=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=RayU/r54hcHrtIb/LaB6KZUh6/la7UfvH1tQYPSm3jKo7t3baamW2wIQR7iusgJQI F3DyeDuW+X32zheseMBpmnVsPeCpVaIr2RIrafK9nSWgWr9JmOU0NSACRGYMKnX3Fh Ery6a32On+7vFfEjCsXo2+ICLgsvHNvm4UVARFSD11wv0McMxt3YI9Xwb0OIiuSsrw KTG1MSCIqTz3k2fSVG4hIfDCEXMBZfRSkMFRHfxOqXigJUQADzuM36W14VJ0qrjWv7 XBgHy01C+4PQn3TAl56YD5lAn72fcHChMQmh2aiZ4+/jnXqnqVL8sRtuxQRq8GJNq8 G5NaYjN31PVLA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v9 04/29] libmultipath: Add path selection support To: "John Garry" , james.bottomley@hansenpartnership.com, mkp@kernel.org Cc: hare@suse.com, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, snitzer@kernel.org, jmeneghi@redhat.com, bmarzins@redhat.com, dm-devel@lists.linux.dev, hch@lst.de, michael.christie@oracle.com In-Reply-To: <20261108204733.557995-5-john.garry@linux.dev> References: <20261108204733.557995-1-john.garry@linux.dev> <20261108204733.557995-5-john.garry@linux.dev> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sun, 08 Nov 2026 21:07:16 +0000 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "Linux-nvme" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Medium] libmultipath: inconsistent path optimization check between is_optimized() and access_state -- commit 5d198416c184ad80e962a53ac50fbd829ed2c691 Author: John Garry libmultipath: Add path selection support This commit adds multipath path selection support for NUMA, round-robin, and queue-depth I/O policies along with path access state abstractions. > diff --git a/lib/multipath.c b/lib/multipath.c > index 93c0ca8b390b1..b8ea8478037ef 100644 > --- a/lib/multipath.c > +++ b/lib/multipath.c > @@ -8,8 +8,245 @@ > #include > #include > =20 > +static struct mpath_device *mpath_find_path(struct mpath_head *mpath_hea= d); > + [ ... ] > +static struct mpath_device *__mpath_find_path(struct mpath_head *mpath_h= ead, > + int node) > +{ > + int found_distance =3D INT_MAX, fallback_distance =3D INT_MAX, distance; > + struct mpath_device *found =3D NULL, *fallback =3D NULL, *mpath_device; > + > + list_for_each_entry_srcu(mpath_device, &mpath_head->dev_list, siblings, > + srcu_read_lock_held(&mpath_head->srcu)) { > + if (mpath_path_is_disabled(mpath_head, mpath_device)) > + continue; > + > + if (mpath_device->numa_node !=3D NUMA_NO_NODE && > + (mpath_read_iopolicy(mpath_head) =3D=3D > + MPATH_IOPOLICY_NUMA)) > + distance =3D node_distance(node, > + mpath_device->numa_node); > + else > + distance =3D LOCAL_DISTANCE; > + > + switch(mpath_device->access_state) { > + case MPATH_STATE_OPTIMIZED: > + if (distance < found_distance) { > + found_distance =3D distance; > + found =3D mpath_device; > + } > + break; > + case MPATH_STATE_NONOPTIMIZED: > + if (distance < fallback_distance) { > + fallback_distance =3D distance; > + fallback =3D mpath_device; > + } > + break; > + default: > + break; > + } > + } [ ... ] > +static inline bool mpath_path_is_optimized(struct mpath_head *mpath_head, > + struct mpath_device *mpath_device) > +{ > + return mpath_head->mpdt->is_optimized(mpath_device); > +} > + > +static struct mpath_device *mpath_numa_path(struct mpath_head *mpath_hea= d) > +{ > + int node =3D numa_node_id(); > + struct mpath_device *mpath_device; > + > + mpath_device =3D srcu_dereference(mpath_head->current_path[node], > + &mpath_head->srcu); > + if (unlikely(!mpath_device)) > + return __mpath_find_path(mpath_head, node); > + if (unlikely(mpath_path_is_disabled(mpath_head, mpath_device))) > + return __mpath_find_path(mpath_head, node); > + if (unlikely(!mpath_path_is_optimized(mpath_head, mpath_device))) > + return __mpath_find_path(mpath_head, node); > + return mpath_device; > +} [Severity: Medium] Should __mpath_find_path(), mpath_round_robin_path(), and mpath_queue_depth_path() check mpath_path_is_optimized() (or a callback returning enum mpath_access_state) instead of reading mpath_device->access_state directly? mpath_numa_path() and mpath_device_set_live() call mpath_path_is_optimized(), which invokes mpath_head->mpdt->is_optimized(), whereas __mpath_find_path(), mpath_round_robin_path(), and mpath_queue_depth_path() inspect mpath_device->access_state. If a driver reports path optimization dynamically through .is_optimized() without updating mpath_device->access_state (or vice versa), the two checks disagree: when current_path[node] is non-optimized according to .is_optimized() but still has access_state set to MPATH_STATE_OPTIMIZED, mpath_numa_path() falls back to __mpath_find_path() on every I/O, and __mpath_find_path() treats that non-optimized path as optimized and can re-select it over a genuinely optimized path at a greater NUMA distance. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261108204733.5579= 95-1-john.garry@linux.dev?part=3D4