From: sashiko-bot@kernel.org
To: "Sreeraj S Kurup" <sreekuttan2156239@gmail.com>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvmet: synchronize DH-CHAP secret removal
Date: Tue, 10 Nov 2026 08:05:14 +0000 [thread overview]
Message-ID: <sashiko-outbox-206563@kernel.org> (raw)
In-Reply-To: <20261110075733.2578-1-sreekuttan2156239@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] nvmet: missing Fixes trailer for nvmet_auth_set_key() secret
clearing fix
--
commit e2778d1ca53fb43c219da377cd2d67684a67c943
Author: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
> nvmet: synchronize DH-CHAP secret removal
>
> The empty-secret path in nvmet_auth_set_key() modifies and frees
> host authentication secrets without holding nvmet_config_sem.
>
> nvmet_setup_auth() accesses these fields under the read lock,
> allowing concurrent secret removal to cause a use-after-free.
>
> Acquire nvmet_config_sem for writing while clearing the secrets
> to synchronize with authentication setup.
>
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
[Severity: Low]
Since this fixes the unlocked empty-secret path added to
nvmet_auth_set_key(), should this include:
Fixes: bb2df18958b4 ("nvmet-auth: allow to clear DH-HMAC-CHAP keys")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261110075733.2578-1-sreekuttan2156239@gmail.com?part=1
next prev parent reply other threads:[~2026-11-10 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 7:57 [PATCH] nvmet: synchronize DH-CHAP secret removal Sreeraj S Kurup
2026-11-10 8:05 ` sashiko-bot [this message]
2026-11-10 12:14 ` Hannes Reinecke
2026-11-10 12:54 ` Sreeraj S Kurup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-206563@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sreekuttan2156239@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox