Re: [PATCH 1/2] nvme: check duplicate unique identifiers in order

Hannes Reinecke
2025-07-22T07:00:30Z

On 7/15/25 21:29, Keith Busch wrote:
> On Tue, Jul 15, 2025 at 03:01:59PM -0400, John Meneghini wrote:
>> On 6/24/25 11:16 AM, Keith Busch wrote:
>>> On Mon, May 12, 2025 at 10:12:29AM -0600, Keith Busch wrote:
>>>> On Mon, May 12, 2025 at 11:18:58AM -0400, John Meneghini wrote:
>>>>> On 5/9/25 11:33 AM, Keith Busch wrote:
>>>>>
>>>>>> If those are not unique, they need to be blanked out to make sure we don't
>>>>>> expose these on the namespace's sysfs attributes.
>>>>>
>>>>> OK, we can add another patch that blanks out the lower precedent/invalid IDs.
>>>>>
>>>>> Will that work?
>>>>
>>>> I think you'd have to blank out the non-unique ones, otherwise the
>>>> driver would export them.
>>>>
>>>> And while I think that might work, this proposal didn't go over so well
>>>> last time it came up:
>>>>
>>>> https://lore.kernel.org/linux-nvme/20250414111916.GB13225@lst.de/
>>>
>>> I've recently encountered some devices with this behavior, from machines
>>> hosted by various cloud providers. I had to pull in something
>>> out-of-tree like the patch here just to get things going. I think we
>>> should have the kernel discard lower priority fields.
>>
>> OK good I will ask Bryan to resubmit this as a version 2 patch.
>> We can add another patch that blanks out the lower precedent/invalid IDs in sysfs so that only the unique IDs are reported.
>
> Note, it's not me who needs convincing.
>
> FWIW, this is what I'm running with. There's just some extra care here
> to ensure we refresh sysfs attributes as needed, as well as prevent
> repeatedly spamming the kernel messages with the same error.
>
Ah, so you got another one?

We got one, too (which is essentially that one posted on the mailing list).

If we now can get Oracle to chime in (maybe with a different patch
altogether?) we have all major vendors implementing different fixes
for the same problem.

Fun ...

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich