From: martin.petersen@oracle.com (Martin K. Petersen)
Subject: [PATCH v3 2/3] nvmet: Export NVMe namespace attributes
Date: Wed, 19 Jun 2019 00:13:06 -0400 [thread overview]
Message-ID: <yq1a7eeusa5.fsf@oracle.com> (raw)
In-Reply-To: <20190617161222.253849-3-bvanassche@acm.org> (Bart Van Assche's message of "Mon, 17 Jun 2019 09:12:21 -0700")
Bart,
> + /*
> + * Physical blocks per logical block, 0's based. Is it possible to
> + * extract this information from the filesystem properties?
> + */
> + const __le16 ppl0b = cpu_to_le16(0);
Maybe report the filesystem block size here?
Otherwise OK.
Reviewed-by: Martin K. Petersen <martin.petersen at oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-06-19 4:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 16:12 [PATCH v3 0/3] NVMe 1.4 Identify Namespace Support Bart Van Assche
2019-06-17 16:12 ` [PATCH v3 1/3] nvme: Introduce NVMe 1.4 Identify Namespace fields in struct nvme_id_ns Bart Van Assche
2019-06-18 7:49 ` Hannes Reinecke
2019-06-17 16:12 ` [PATCH v3 2/3] nvmet: Export NVMe namespace attributes Bart Van Assche
2019-06-18 7:50 ` Hannes Reinecke
2019-06-19 4:13 ` Martin K. Petersen [this message]
2019-06-19 15:44 ` Bart Van Assche
2019-06-21 1:56 ` Martin K. Petersen
2019-06-21 15:19 ` Bart Van Assche
2019-06-24 23:30 ` Martin K. Petersen
2019-06-24 23:51 ` Bart Van Assche
2019-06-20 3:19 ` Chaitanya Kulkarni
2019-06-17 16:12 ` [PATCH v3 3/3] nvme: Set physical block size and optimal I/O size according to NVMe 1.4 Bart Van Assche
2019-06-18 7:51 ` Hannes Reinecke
2019-06-19 4:17 ` Martin K. Petersen
2019-06-18 7:52 ` [PATCH v3 0/3] NVMe 1.4 Identify Namespace Support Hannes Reinecke
2019-06-18 20:34 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1a7eeusa5.fsf@oracle.com \
--to=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).