From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Keith Busch <kbusch@meta.com>
Cc: <linux-block@vger.kernel.org>, <linux-nvme@lists.infradead.org>,
<hch@lst.de>, <axboe@kernel.dk>, <joshi.k@samsung.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv7 7/9] blk-integrity: use iterator for mapping sg
Date: Wed, 13 Aug 2025 12:53:46 -0400 [thread overview]
Message-ID: <yq1ikir2mff.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250813153153.3260897-8-kbusch@meta.com> (Keith Busch's message of "Wed, 13 Aug 2025 08:31:51 -0700")
Keith,
> Modify blk_rq_map_integrity_sg to use the blk-mq mapping iterator.
> This produces more efficient code and converges the integrity mapping
> implementations to reduce future maintenance burdens.
>
> The function implementation moves from blk-integrity.c to blk-mq-dma.c
> in order to use the types and functions private to that file.
Very nice!
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen
next prev parent reply other threads:[~2025-08-13 18:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 15:31 [PATCHv7 0/9] blk dma iter for integrity metadata Keith Busch
2025-08-13 15:31 ` [PATCHv7 1/9] blk-mq-dma: create blk_map_iter type Keith Busch
2025-08-14 10:17 ` Kanchan Joshi
2025-08-13 15:31 ` [PATCHv7 2/9] blk-mq-dma: provide the bio_vec array being iterated Keith Busch
2025-08-14 10:17 ` Kanchan Joshi
2025-08-13 15:31 ` [PATCHv7 3/9] blk-mq-dma: require unmap caller provide p2p map type Keith Busch
2025-08-13 15:53 ` Christoph Hellwig
2025-08-14 10:18 ` Kanchan Joshi
2025-08-13 15:31 ` [PATCHv7 4/9] blk-mq: remove REQ_P2PDMA flag Keith Busch
2025-08-13 15:53 ` Christoph Hellwig
2025-08-14 10:19 ` Kanchan Joshi
2025-08-13 15:31 ` [PATCHv7 5/9] blk-mq-dma: move common dma start code to a helper Keith Busch
2025-08-13 15:53 ` Christoph Hellwig
2025-08-14 10:19 ` Kanchan Joshi
2025-08-13 15:31 ` [PATCHv7 6/9] blk-mq-dma: add scatter-less integrity data DMA mapping Keith Busch
2025-08-13 15:55 ` Christoph Hellwig
2025-08-14 10:36 ` Kanchan Joshi
2025-08-13 15:31 ` [PATCHv7 7/9] blk-integrity: use iterator for mapping sg Keith Busch
2025-08-13 15:55 ` Christoph Hellwig
2025-08-13 16:53 ` Martin K. Petersen [this message]
2025-08-13 15:31 ` [PATCHv7 8/9] nvme-pci: create common sgl unmapping helper Keith Busch
2025-08-13 15:56 ` Christoph Hellwig
2025-08-13 15:31 ` [PATCHv7 9/9] nvme-pci: convert metadata mapping to dma iter Keith Busch
2025-08-13 16:57 ` [PATCHv7 0/9] blk dma iter for integrity metadata Martin K. Petersen
2025-08-25 7:55 ` Christoph Hellwig
2025-08-25 13:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ikir2mff.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).