From: martin.petersen@oracle.com (Martin K. Petersen)
Subject: [PATCH] nvme: Honor RTD3 Entry Latency for shutdowns
Date: Thu, 17 Aug 2017 13:06:32 -0400 [thread overview]
Message-ID: <yq1o9rektt3.fsf@oracle.com> (raw)
In-Reply-To: <20170817150113.GL7233@localhost.localdomain> (Keith Busch's message of "Thu, 17 Aug 2017 11:01:13 -0400")
Keith,
>> > My only concern is if this value extends past the DPM_WATCHDOG
>> > timeout value. If it does we're going to end up panic()ing the
>> > kernel during suspends. If others agree I think we should set it to
>> > the minimum value of DPM_WATCHDOG_TIMEOUT and shutdown_timeout.
>>
>> I don't have a problem with that. Keith?
>
> Sounds good to me as well.
Hrm, this gets pretty messy.
DPM_WATCHDOG_TIMEOUT is buried deep in the config options (hidden behind
PM_DEBUG and EXPERT). And as a result doesn't appear to be enabled in
most common kernel configs. It also isn't exported from the PM subsystem
in a generic way.
In addition, I'm not sure what we'd do in case a device demands a 10
second shutdown time but the user has the kernel configured with a 2
second DPM watchdog. Then what? The device is still going to take 10
seconds to complete the shutdown request.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-08-17 17:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 19:55 [PATCH] nvme: Honor RTD3 Entry Latency for shutdowns Martin K. Petersen
2017-08-16 20:25 ` Scott Bauer
2017-08-16 20:49 ` Martin K. Petersen
2017-08-17 15:01 ` Keith Busch
2017-08-17 17:06 ` Martin K. Petersen [this message]
2017-08-17 17:42 ` Scott Bauer
2017-08-23 22:32 ` [PATCH v2] " Martin K. Petersen
2017-08-24 9:02 ` Christoph Hellwig
2017-08-25 2:26 ` Martin K. Petersen
2017-08-25 2:26 ` [PATCH v3] " Martin K. Petersen
2017-08-25 7:41 ` Christoph Hellwig
2017-08-25 14:15 ` Martin K. Petersen
2017-08-25 19:56 ` Keith Busch
2017-08-25 23:14 ` [PATCH v4] " Martin K. Petersen
2017-08-28 6:05 ` Sagi Grimberg
2017-08-28 14:22 ` Keith Busch
2017-08-25 23:16 ` [PATCH v3] " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1o9rektt3.fsf@oracle.com \
--to=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox