From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Keith Busch <kbusch@meta.com>
Cc: <axboe@kernel.dk>, <linux-block@vger.kernel.org>,
<martin.petersen@oracle.com>, <hch@lst.de>,
<linux-nvme@lists.infradead.org>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] block: always allocate integrity buffer
Date: Wed, 07 May 2025 14:42:19 -0400 [thread overview]
Message-ID: <yq1selgtgao.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250507153759.1199895-1-kbusch@meta.com> (Keith Busch's message of "Wed, 7 May 2025 08:37:59 -0700")
Keith,
> The integrity buffer is mandatory for nvme formats that have metadata
> whether or not you want it generated or verified. The block integrity
> attributes read_verify and write_generate had been stopping the
> metadata buffer from being allocated and attached to the bio entirely.
> We only want to suppress the protection checks on the device and host,
> but we still need the buffer.
Looks OK to me.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen
next prev parent reply other threads:[~2025-05-07 18:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 15:37 [PATCH] block: always allocate integrity buffer Keith Busch
2025-05-07 18:37 ` Jens Axboe
2025-05-07 18:42 ` Martin K. Petersen [this message]
2025-05-07 19:03 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1selgtgao.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox