From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: Keith Busch <kbusch@kernel.org>,
axboe@kernel.dk, hch@lst.de, martin.petersen@oracle.com,
sagi@grimberg.me, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, gost.dev@samsung.com,
Chinmay Gameti <c.gameti@samsung.com>
Subject: Re: [PATCH v2 2/3] block: support PI at non-zero offset within metadata
Date: Mon, 30 Sep 2024 13:57:45 -0400 [thread overview]
Message-ID: <yq1ttdx81ub.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <165deefb-a8b3-594e-9bfb-b3bcd588d23f@samsung.com> (Kanchan Joshi's message of "Fri, 27 Sep 2024 21:37:54 +0530")
Kanchan,
> I spent a good deal of time on this today. I was thinking to connect
> block read_verify/write_generate knobs to influence things at nvme level
> (those PRCHK flags). But that will not be enough. Because with those
> knobs block-layer will not attach meta-buffer, which is still needed.
>
> The data was written under the condition when nvme driver set the
> pi_type to 0 (even though at device level it was non-zero) during
> integrity registration.
>
> Thinking whether it will make sense to have a knob at the block-layer
> level to do something like that i.e., override the set
> integrity-profile with nop.
SCSI went to great lengths to ensure that invalid protection information
would never be written during normal operation, regardless of whether
the host sent PI or not. And thus the only time one would anticipate a
PI error was if the data had actually been corrupted.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2024-09-30 17:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240201130828epcas5p10bd98bcb6b8e9444603e347c2a910c44@epcas5p1.samsung.com>
2024-02-01 13:01 ` [PATCH v2 0/3] Block integrity with flexible-offset PI Kanchan Joshi
2024-02-01 13:01 ` [PATCH v2 1/3] block: refactor guard helpers Kanchan Joshi
2024-02-01 13:01 ` [PATCH v2 2/3] block: support PI at non-zero offset within metadata Kanchan Joshi
2024-09-26 15:07 ` Keith Busch
2024-09-26 16:38 ` Kanchan Joshi
2024-09-26 16:55 ` Keith Busch
2024-09-27 16:07 ` Kanchan Joshi
2024-09-30 17:57 ` Martin K. Petersen [this message]
2024-10-01 7:27 ` Javier González
2024-10-01 15:37 ` Keith Busch
2024-10-02 10:29 ` Javier González
2024-10-02 16:18 ` Martin K. Petersen
2024-10-02 19:03 ` Keith Busch
2024-02-01 13:01 ` [PATCH v2 3/3] nvme: allow integrity when PI is not in first bytes Kanchan Joshi
2024-02-12 15:47 ` [PATCH v2 0/3] Block integrity with flexible-offset PI Kanchan Joshi
2024-02-12 15:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ttdx81ub.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=c.gameti@samsung.com \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox