Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: martin.petersen@oracle.com (Martin K. Petersen)
Subject: [PATCH 3/4] block: Refuse adding appending a gaped integrity page to a bio
Date: Thu, 10 Sep 2015 18:22:47 -0400	[thread overview]
Message-ID: <yq1twr13oeg.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <55F1490C.7050105@dev.mellanox.co.il> (Sagi Grimberg's message of "Thu, 10 Sep 2015 12:10:36 +0300")

>>>>> "Sagi" == Sagi Grimberg <sagig at dev.mellanox.co.il> writes:

>> For some workloads I think bouncing is inevitable by virtue of the PI
>> payload being teeny tiny by design.

Sagi> I see. I guess we can bounce DIX data, but is it always "right" to
Sagi> bounce? I don't know, as you say, it is workload dependent.

The right place to make that call, I guess, is in
bio_integrity_add_page() based on whether we exceed any of the
constraints set by the LLD.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2015-09-10 22:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-03 16:28 [PATCH 0/4] Fix gaps detection in bio merges Sagi Grimberg
2015-09-03 16:28 ` [PATCH 1/4] block: Check for gaps on front and back merges Sagi Grimberg
2015-09-03 16:28 ` [PATCH 2/4] block: Refuse request/bio merges with gaps in the integrity payload Sagi Grimberg
2015-09-03 16:28 ` [PATCH 3/4] block: Refuse adding appending a gaped integrity page to a bio Sagi Grimberg
2015-09-04  3:24   ` Martin K. Petersen
2015-09-06  7:46     ` Sagi Grimberg
2015-09-08 18:24       ` Martin K. Petersen
2015-09-10  9:10         ` Sagi Grimberg
2015-09-10 22:22           ` Martin K. Petersen [this message]
2015-09-13  7:53             ` Sagi Grimberg
2015-09-03 16:28 ` [PATCH 4/4] block: Copy a user iovec if it includes gaps Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1twr13oeg.fsf@sermon.lab.mkp.net \
    --to=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox