From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kbusch@kernel.org, sagi@grimberg.me, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvme: implement the DEAC bit for the Write Zeroes command
Date: Mon, 07 Nov 2022 12:10:35 -0500 [thread overview]
Message-ID: <yq1zgd2lmi8.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20221107162108.1777681-1-hch@lst.de> (Christoph Hellwig's message of "Mon, 7 Nov 2022 17:21:08 +0100")
Christoph,
> While the specification allows devices to either deallocate data or to
> actually write zeroes on any Write Zeroes command, many SSDs only do
> the sensible thing and deallocate data when the DEAC bit is specific.
> Set it when it is suppored and the caller doesn't explicitly opt out
supported
> of deallocation.
Looks good.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-11-07 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 16:21 [PATCH v2] nvme: implement the DEAC bit for the Write Zeroes command Christoph Hellwig
2022-11-07 16:30 ` Keith Busch
2022-11-07 17:10 ` Martin K. Petersen [this message]
2022-11-08 3:54 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1zgd2lmi8.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox