From: "Maulik" <x0082077@ti.com>
To: 'Olof Johansson' <olof@lixom.net>, 'Tony Lindgren' <tony@atomide.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
'Felipe Balbi' <felipe.balbi@nokia.com>,
'Greg Kroah-Hartman' <gregkh@suse.de>,
'David Brownell' <david-b@pacbell.net>
Subject: RE: [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig
Date: Fri, 26 Feb 2010 14:10:31 +0530 [thread overview]
Message-ID: <000001cab6bf$5df75720$808918ac@apr.dhcp.ti.com> (raw)
In-Reply-To: <20100226004233.GA3241@lixom.net>
> > @@ -153,7 +157,7 @@ config MUSB_PIO_ONLY
> > config USB_INVENTRA_DMA
> > bool
> > depends on USB_MUSB_HDRC && !MUSB_PIO_ONLY
> > - default ARCH_OMAP2430 || ARCH_OMAP34XX || BLACKFIN
> > + default ARCH_OMAP2430 || ARCH_OMAP34XX || BLACKFIN || ARCH_OMAP4
> > help
> > Enable DMA transfers using Mentor's engine.
>
> FYI, this needs to be updated as I have patches queued up
> to replace ARCH_OMAP34XX and with ARCH_OMAP3. You might
> want to check all these patches for that and make sure
> they build and work with the omap-for-linus branch.
Tony,
I shall post a newer version after rebasing and fixing the comments.
I believe your patches will soon make to mainline :-)
>>Adding more and more depends also doesn't scale well. It's time for
>>someone to switch the test around, add a ARCH_HAS_MUSB, select it on
>>the platforms that has it and make the config option depend on that,
>>similar to how (some) platforms to EHCI today.
>>(i.e. if there's a janitor out there reading this, feel free to go ahead
>>and do it. :-)
Olof,
We have such an option "USB_MUSB_SOC" that takes care of all platforms where
MUSB is present. But the Inventra DMA case is typical. Not all architectures
that have MUSB use Inventra DMA for e.g Davinci uses CPPI DMA.
Thanks,
Maulik
next prev parent reply other threads:[~2010-02-26 8:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 6:35 [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig Maulik Mankad
[not found] ` <1267079758-14480-1-git-send-email-x0082077-l0cyMroinI0@public.gmane.org>
2010-02-25 18:48 ` Tony Lindgren
2010-02-26 0:42 ` Olof Johansson
2010-02-26 8:40 ` Maulik [this message]
2010-02-26 18:54 ` Olof Johansson
[not found] ` <20100226185414.GA10835-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2010-03-01 5:41 ` Maulik
[not found] ` <001b01cab901$dadec9a0$808918ac-wD+IZp/g4/2mHdYHvhjUOg@public.gmane.org>
2010-03-01 15:43 ` Olof Johansson
[not found] ` <20100301154329.GA4154-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2010-03-10 10:17 ` Maulik
[not found] ` <00f701cac03a$da51cab0$808918ac-wD+IZp/g4/2mHdYHvhjUOg@public.gmane.org>
2010-03-10 18:27 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001cab6bf$5df75720$808918ac@apr.dhcp.ti.com' \
--to=x0082077@ti.com \
--cc=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=gregkh@suse.de \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=olof@lixom.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox