From: "Srinath R" <srinath@mistralsolutions.com>
To: "'Premi, Sanjeev'" <premi@ti.com>, linux-omap@vger.kernel.org
Cc: "'Kridner, Jason'" <jdk@ti.com>,
tony@atomide.com, khilman@deeprootsystems.com, "'Menon,
Nishanth'" <nm@ti.com>,
nagendra@mistralsolutions.com, umeshk@mistralsolutions.com
Subject: RE: [Patch v3] OMAP: AM3517/05: Add craneboard support
Date: Fri, 29 Oct 2010 10:32:14 +0530 [thread overview]
Message-ID: <000001cb7726$77a7cf60$66f76e20$@com> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB593023475E6FE@dbde02.ent.ti.com>
-----Original Message-----
From: Premi, Sanjeev [mailto:premi@ti.com]
Sent: Thursday, October 28, 2010 7:47 PM
To: srinath@mistralsolutions.com; linux-omap@vger.kernel.org
Cc: Kridner, Jason; tony@atomide.com; khilman@deeprootsystems.com; Menon,
Nishanth; nagendra@mistralsolutions.com; umeshk@mistralsolutions.com
Subject: RE: [Patch v3] OMAP: AM3517/05: Add craneboard support
> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org
> [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of
> srinath@mistralsolutions.com
> Sent: Thursday, October 28, 2010 6:59 PM
> To: linux-omap@vger.kernel.org
> Cc: Kridner, Jason; tony@atomide.com;
> khilman@deeprootsystems.com; Menon, Nishanth;
> nagendra@mistralsolutions.com; umeshk@mistralsolutions.com; Srinath
> Subject: [Patch v3] OMAP: AM3517/05: Add craneboard support
>
[snip]
> +MACHINE_START(CRANEBOARD, "AM3517/05 CRANEBOARD")
Compared against AM3715, I see these missing:
.phys_io = 0x48000000,
.io_pg_offst = ((0xd8000000) >> 18) & 0xfffc,
Are these not required?
[Srintah] According to commit ID de01f1735c9a8c00b3625507c7327a1f0b347b7b,
io_pg_offst and phys_io members are
no more required in struct machine_desc
> + .boot_params = 0x80000100,
> + .map_io = omap3_map_io,
> + .reserve = omap_reserve,
^^^^^^^^
Check for mix of space & tabs here.
[Srintah] Sure, I will update and re-submit patch
~sanjeev
> + .init_irq = am3517_crane_init_irq,
> + .init_machine = am3517_crane_init,
> + .timer = &omap_timer,
> +MACHINE_END
> diff --git a/arch/arm/plat-omap/include/plat/uncompress.h
> b/arch/arm/plat-omap/include/plat/uncompress.h
> index 9036e37..229fbf2 100644
> --- a/arch/arm/plat-omap/include/plat/uncompress.h
> +++ b/arch/arm/plat-omap/include/plat/uncompress.h
> @@ -145,6 +145,7 @@ static inline void
> __arch_decomp_setup(unsigned long arch_id)
> /* omap3 based boards using UART3 */
> DEBUG_LL_OMAP3(3, cm_t35);
> DEBUG_LL_OMAP3(3, cm_t3517);
> + DEBUG_LL_OMAP3(3, craneboard);
> DEBUG_LL_OMAP3(3, igep0020);
> DEBUG_LL_OMAP3(3, igep0030);
> DEBUG_LL_OMAP3(3, nokia_rx51);
> --
> 1.7.1.226.g770c5
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> =
next prev parent reply other threads:[~2010-10-29 4:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH] OMAP: AM3517/05: Add craneboard support>
2010-10-28 13:29 ` [Patch v3] OMAP: AM3517/05: Add craneboard support srinath
2010-10-28 14:16 ` Premi, Sanjeev
2010-10-29 5:02 ` Srinath R [this message]
2010-10-29 7:13 ` [Patch v4] " srinath
2010-10-29 9:32 ` Premi, Sanjeev
2010-11-05 21:54 ` Tony Lindgren
2010-11-09 14:13 ` [Patch v5] " srinath
2010-11-16 21:19 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001cb7726$77a7cf60$66f76e20$@com' \
--to=srinath@mistralsolutions.com \
--cc=jdk@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=nagendra@mistralsolutions.com \
--cc=nm@ti.com \
--cc=premi@ti.com \
--cc=tony@atomide.com \
--cc=umeshk@mistralsolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).