public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH 1/2] OMAP: Add OMAP_LDP platform support.
@ 2008-12-04  9:44 Sam Duan
  2008-12-04 11:28 ` stanley.miao
  0 siblings, 1 reply; 3+ messages in thread
From: Sam Duan @ 2008-12-04  9:44 UTC (permalink / raw)
  To: linux-omap; +Cc: 'Stanley.Miao'

Hi Stanley,

I git clone the
tree(http://www.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.gi
t)
and configured the kernel with omap_ldp_defconfig but met some compile
errors.
It seems like the line "gpio_direction_input(eth_gpio) " was not patched in.
It's "omap_set_gpio_direction(eth_gpio, 1)" at Line343 in
arch/arm/mach-omap2/board-ldp.c which caused an error "implicit
declaration";
I replaced omap_set_gpio_direction(eth_gpio, 1) with
gpio_direction_input(eth_gpio) but the same error appeared with
drivers/video/omap/lcd_ldp.c for "omap_set_gpio_direction" and
"omap_set_gpio_dataout".
 
Did I miss some other patches? Are there any patchs can make the kernel
compiled with omap_ldp_defconfig?
Thanks
Sam


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCHv2 0/3] OMAP_LDP support in linux-git tree
@ 2008-11-26 23:12 Tony Lindgren
  2008-11-27 15:34 ` [PATCH 1/2] OMAP: Add OMAP_LDP platform support Stanley.Miao
  0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2008-11-26 23:12 UTC (permalink / raw)
  To: Stanley.Miao; +Cc: linux-omap

* Stanley.Miao <stanley.miao@windriver.com> [081120 23:45]:
> Changes from v1:
> 
> 1, change omap_request_gpio() to gpio_request() in gpio.patch.

One request: Since the LDP is in the mainline kernel, can you please
provide whatever applies as patches against the mainline board-ldp.c?

Then if some driver is not yet in mainline, provide that in an extra
patch.

That way I don't have to rewrite your patches for mainline ;)

Tony

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-12-04 11:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-04  9:44 [PATCH 1/2] OMAP: Add OMAP_LDP platform support Sam Duan
2008-12-04 11:28 ` stanley.miao
  -- strict thread matches above, loose matches on Subject: below --
2008-11-26 23:12 [PATCHv2 0/3] OMAP_LDP support in linux-git tree Tony Lindgren
2008-11-27 15:34 ` [PATCH 1/2] OMAP: Add OMAP_LDP platform support Stanley.Miao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox