From: "Rajendra Nayak" <rnayak@ti.com>
To: 'Russell King - ARM Linux' <linux@arm.linux.org.uk>
Cc: linux-omap@vger.kernel.org
Subject: RE: [PATCH 02/12] serial context save/restore
Date: Tue, 2 Sep 2008 09:20:22 +0530 [thread overview]
Message-ID: <001f01c90caf$07d4da90$LocalHost@wipultra1382> (raw)
In-Reply-To: <20080901200633.GD28999@flint.arm.linux.org.uk>
> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux@arm.linux.org.uk]
> Sent: Tuesday, September 02, 2008 1:37 AM
> To: Rajendra Nayak
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH 02/12] serial context save/restore
>
> On Mon, Sep 01, 2008 at 07:07:27PM +0530, Rajendra Nayak wrote:
> > This patch adds the context save restore functions for UART
> > --- linux-omap-2.6.orig/include/linux/serial_reg.h 2008-09-01
> > 18:11:29.000000000 +0530
> > +++ linux-omap-2.6/include/linux/serial_reg.h
> 2008-09-01 18:11:50.000000000 +0530
> > @@ -323,6 +323,7 @@
> > #define UART_OMAP_MVER 0x14 /* Module
> version register */
> > #define UART_OMAP_SYSC 0x15 /* System
> configuration register */
> > #define UART_OMAP_SYSS 0x16 /* System
> status register */
> > +#define UART_OMAP_WER 0x17 /* Wake-up enable
> register */
>
> Please match the indentation style.
> >
> > #endif /* _LINUX_SERIAL_REG_H */
> >
> > Index: linux-omap-2.6/arch/arm/plat-omap/include/mach/serial.h
> > ===================================================================
> > ---
> linux-omap-2.6.orig/arch/arm/plat-omap/include/mach/serial.h
> 2008-09-01
> > 18:11:29.000000000 +0530
> > +++ linux-omap-2.6/arch/arm/plat-omap/include/mach/serial.h
> 2008-09-01
> > 18:11:50.000000000 +0530
> > @@ -39,5 +39,16 @@
> > __ret = 1; \
> > __ret; \
> > })
> > -
> > +#ifndef __ASSEMBLY__
>
> There should be a blank line between the previous macro and this
> ifndef.
Ok. I'll repost this patch with the fixes.
>
>
next prev parent reply other threads:[~2008-09-02 3:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 13:37 [PATCH 02/12] serial context save/restore Rajendra Nayak
2008-09-01 20:06 ` Russell King - ARM Linux
2008-09-02 3:50 ` Rajendra Nayak [this message]
2008-09-04 8:52 ` Kevin Hilman
[not found] <59386.192.168.10.89.1220276248.squirrel@dbdmail.itg.ti.com>
2008-09-02 7:52 ` Rajendra Nayak
2008-09-02 11:30 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001f01c90caf$07d4da90$LocalHost@wipultra1382' \
--to=rnayak@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox